Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_remote_config] Fix Future already completed RemoteConfig.instance #1966

Closed
wants to merge 4 commits into from
Closed

[firebase_remote_config] Fix Future already completed RemoteConfig.instance #1966

wants to merge 4 commits into from

Conversation

IchordeDionysos
Copy link

@IchordeDionysos IchordeDionysos commented Aug 10, 2019

Description

Fix Future already completed for calling multiple RemoteConfig.instance initially in parallel

Related Issues

flutter/flutter#38060

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

Fix Future already completed for calling multiple RemoteConfig.instance initially in parallel
@collinjackson
Copy link
Contributor

Migrated to firebase/flutterfire#28

Note: It seems the plugin was working fine and this behavior is covered by a test, we just need to remove the spurious error message.

kroikie added a commit to firebase/flutterfire that referenced this pull request Aug 30, 2019
[firebase_remote_config] Fix Future already completed RemoteConfig.instance
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants