This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Add tests in path_provider and url_launcher plugins #22
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
43dbddd
wip
szakarias fc0b5aa
url_launcher test + missing copyrights
szakarias 84cb5f5
formatting
szakarias 2a6cc75
split into smaller tests
szakarias 87f6f58
formatting
szakarias 3b52e07
Merge branch 'master' of github.com:flutter/plugins into addTests
szakarias File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
// Copyright 2017 The Chromium Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
import 'dart:io'; | ||
|
||
import 'package:flutter/services.dart'; | ||
import 'package:path_provider/path_provider.dart'; | ||
import 'package:test/test.dart'; | ||
|
||
void main() { | ||
test('Path provider control test', () async { | ||
final List<MethodCall> log = <MethodCall>[]; | ||
String response; | ||
const channel = const MethodChannel('plugins.flutter.io/path_provider'); | ||
|
||
channel.setMockMethodCallHandler((MethodCall methodCall) async { | ||
log.add(methodCall); | ||
return response; | ||
}); | ||
|
||
Directory directory = await getTemporaryDirectory(); | ||
|
||
expect(log, equals(<MethodCall>[new MethodCall('getTemporaryDirectory')])); | ||
expect(directory, isNull); | ||
log.clear(); | ||
|
||
directory = await getApplicationDocumentsDirectory(); | ||
|
||
expect( | ||
log, | ||
equals( | ||
<MethodCall>[new MethodCall('getApplicationDocumentsDirectory')])); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A trailing comma may make |
||
expect(directory, isNull); | ||
|
||
final String fakePath = "/foo/bar/baz"; | ||
response = fakePath; | ||
|
||
directory = await getTemporaryDirectory(); | ||
expect(directory.path, equals(fakePath)); | ||
|
||
directory = await getApplicationDocumentsDirectory(); | ||
expect(directory.path, equals(fakePath)); | ||
}); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
// Copyright 2017 The Chromium Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
import 'package:flutter/services.dart'; | ||
import 'package:test/test.dart'; | ||
import 'package:url_launcher/url_launcher.dart'; | ||
|
||
void main() { | ||
test('URL launcher control test', () async { | ||
final List<MethodCall> log = <MethodCall>[]; | ||
const channel = const MethodChannel('plugins.flutter.io/url_launcher'); | ||
|
||
channel.setMockMethodCallHandler((MethodCall methodCall) async { | ||
log.add(methodCall); | ||
}); | ||
|
||
await canLaunch('http://example.com/'); | ||
expect( | ||
log, | ||
equals( | ||
<MethodCall>[new MethodCall('canLaunch', 'http://example.com/')])); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here. |
||
log.clear(); | ||
|
||
await launch('http://example.com/'); | ||
expect(log, | ||
equals(<MethodCall>[new MethodCall('launch', 'http://example.com/')])); | ||
}); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We start a new test here. Should ideally be separated into two invocations of
test
.