Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[android_alarm_manager] remove MainActivity references #2622

Merged
merged 3 commits into from
Mar 26, 2020

Conversation

cyanglaz
Copy link
Contributor

Description

Following up 899744f
The MainActivity was removed but there were still references left.

Related Issues

fix ci.

Copy link
Contributor

@GaryQian GaryQian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for catching this!

@cyanglaz
Copy link
Contributor Author

Landing to fix CI.

@cyanglaz cyanglaz merged commit 8be1eac into flutter:master Mar 26, 2020
@cyanglaz cyanglaz deleted the android_alarm_manager_activity branch March 26, 2020 23:20
@vkammerer
Copy link

@cyanglaz @GaryQian : is there still additional cleanup to be done in this plugin following 899744f ?

It looks like we could:

<application android:name="io.flutter.app.FlutterApplication" >

This would simplify a lot the usage of this plugin, which can still be quite confusing for new users.

If you think these tasks can be done I'd be happy to open a PR.
I may be missing other cleanup tasks that would also need to be done, if so please let me know.

@vkammerer
Copy link

vkammerer commented Mar 29, 2020

I shouldn't have posted this question in this thread. Moving my question to #2613 (comment)

EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants