Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[scripts] Exclude shared_preferences_windows package #2630

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

franciscojma86
Copy link
Contributor

Description

Includes shared_preferences_windows in the to avoid build failures caused by path dependencies.

Related Issues

flutter/flutter#44918

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@franciscojma86 franciscojma86 merged commit 92e4145 into flutter:master Apr 3, 2020
@Sunbreak
Copy link
Contributor

Sunbreak commented Apr 3, 2020

@franciscojma86 Does it mean that we'll have shared_preference_windows soon?

We're deliverying desktop APPs around and need it despreately.
https://github.com/woodemi/Flutter-SDK-Desktop
https://github.com/woodemi/Flutter-RTM-Desktop

Could you share any preview implementation?

@franciscojma86
Copy link
Contributor Author

@Sunbreak Still a draft, but getting close #2631

jerryzhoujw pushed a commit to jerryzhoujw/plugins that referenced this pull request Apr 10, 2020
EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants