Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in] Make the Delegate non-final to allow overriding #2660

Merged
merged 12 commits into from
Apr 17, 2020
Merged

[google_sign_in] Make the Delegate non-final to allow overriding #2660

merged 12 commits into from
Apr 17, 2020

Conversation

zhenqiu1101
Copy link
Contributor

@zhenqiu1101 zhenqiu1101 commented Apr 17, 2020

Description

Make the Delegate non-final to allow overriding. IDelegate is not enough for v2 embedding for GoogleSignIn and 1p auth plugin because activity and activity binding have to be involved. If we keep Delegate as a field for those plugins, make Delegate non-final so that it's easier for tests to override.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@zhenqiu1101
Copy link
Contributor Author

@cyanglaz Hi Chris, could you help me to merge? I don't have the team role yet.

@myomyintaung1411
Copy link

Exception has occurred.
MissingPluginException (MissingPluginException(No implementation found for method share on channel plugins.flutter.io/share))

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cyanglaz cyanglaz merged commit 6b6be74 into flutter:master Apr 17, 2020
EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
…tter#2660)

Make the Delegate non-final to allow overriding. IDelegate is not enough for v2 embedding for GoogleSignIn and 1p auth plugin because activity and activity binding have to be involved. If we keep Delegate as a field for those plugins, make Delegate non-final so that it's easier for tests to override.
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
…tter#2660)

Make the Delegate non-final to allow overriding. IDelegate is not enough for v2 embedding for GoogleSignIn and 1p auth plugin because activity and activity binding have to be involved. If we keep Delegate as a field for those plugins, make Delegate non-final so that it's easier for tests to override.
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
…tter#2660)

Make the Delegate non-final to allow overriding. IDelegate is not enough for v2 embedding for GoogleSignIn and 1p auth plugin because activity and activity binding have to be involved. If we keep Delegate as a field for those plugins, make Delegate non-final so that it's easier for tests to override.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants