This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[google_sign_in] Make the Delegate non-final to allow overriding #2660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cyanglaz Hi Chris, could you help me to merge? I don't have the team role yet. |
Exception has occurred. |
cyanglaz
approved these changes
Apr 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
…tter#2660) Make the Delegate non-final to allow overriding. IDelegate is not enough for v2 embedding for GoogleSignIn and 1p auth plugin because activity and activity binding have to be involved. If we keep Delegate as a field for those plugins, make Delegate non-final so that it's easier for tests to override.
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
…tter#2660) Make the Delegate non-final to allow overriding. IDelegate is not enough for v2 embedding for GoogleSignIn and 1p auth plugin because activity and activity binding have to be involved. If we keep Delegate as a field for those plugins, make Delegate non-final so that it's easier for tests to override.
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
…tter#2660) Make the Delegate non-final to allow overriding. IDelegate is not enough for v2 embedding for GoogleSignIn and 1p auth plugin because activity and activity binding have to be involved. If we keep Delegate as a field for those plugins, make Delegate non-final so that it's easier for tests to override.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the Delegate non-final to allow overriding. IDelegate is not enough for v2 embedding for GoogleSignIn and 1p auth plugin because activity and activity binding have to be involved. If we keep Delegate as a field for those plugins, make Delegate non-final so that it's easier for tests to override.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?