Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[path_provider] Change Linux example to depend on endorsed plugin from pub.dev #2809

Conversation

TimWhiting
Copy link
Contributor

@TimWhiting TimWhiting commented Jun 2, 2020

Description

This is a simple pull request to update the dependencies of the path_provider_linux example to depend on the endorsed plugin, rather than a local path.

I also took the liberty of removing the example/ios and example/android folders, since those are no longer required. (#2804)

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@TimWhiting
Copy link
Contributor Author

@stuartmorgan
Ready for review. This is just updating the linux example to depend on endorsed plugin, and removing the now unnecessary ios and android folders from the example.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! Just one issue.

@TimWhiting
Copy link
Contributor Author

@stuartmorgan
Done!

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan stuartmorgan merged commit 881552e into flutter:master Jun 3, 2020
@TimWhiting TimWhiting deleted the path_provider_linux_depend_on_published branch June 3, 2020 17:56
EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
…m pub.dev (flutter#2809)

Removes ios and android folders from example, and adopts the published version of path_provider
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
…m pub.dev (flutter#2809)

Removes ios and android folders from example, and adopts the published version of path_provider
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
…m pub.dev (flutter#2809)

Removes ios and android folders from example, and adopts the published version of path_provider
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants