This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[path_provider] Change Linux example to depend on endorsed plugin from pub.dev #2809
Merged
stuartmorgan
merged 4 commits into
flutter:master
from
TimWhiting:path_provider_linux_depend_on_published
Jun 3, 2020
Merged
[path_provider] Change Linux example to depend on endorsed plugin from pub.dev #2809
stuartmorgan
merged 4 commits into
flutter:master
from
TimWhiting:path_provider_linux_depend_on_published
Jun 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d version of path_provider
…_depend_on_published
@stuartmorgan |
stuartmorgan
suggested changes
Jun 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup! Just one issue.
@stuartmorgan |
stuartmorgan
approved these changes
Jun 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
…m pub.dev (flutter#2809) Removes ios and android folders from example, and adopts the published version of path_provider
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
…m pub.dev (flutter#2809) Removes ios and android folders from example, and adopts the published version of path_provider
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
…m pub.dev (flutter#2809) Removes ios and android folders from example, and adopts the published version of path_provider
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a simple pull request to update the dependencies of the
path_provider_linux
example to depend on the endorsed plugin, rather than a local path.I also took the liberty of removing the
example/ios
andexample/android
folders, since those are no longer required. (#2804)Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?