Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] Add web support to the example app. #2816

Merged
merged 5 commits into from
Jun 5, 2020
Merged

[image_picker] Add web support to the example app. #2816

merged 5 commits into from
Jun 5, 2020

Conversation

ditman
Copy link
Member

@ditman ditman commented Jun 4, 2020

Description

This plugin adds web support to the example app, following the instructions of the new package.

The web-app corresponding to this PR has been deployed here:

https://dit-picker-tests.web.app

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@ditman ditman requested a review from cyanglaz June 4, 2020 19:29
@ditman
Remove unneeded comments
fdcb054 
Removed a couple of outdated comments.
cyanglaz
cyanglaz approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo nits

packages/image_picker/image_picker/example/lib/main.dart Show resolved Hide resolved
@ditman
Link to the docs for kIsWeb
6cc4293 
Link to the docs explaining why Image is created with the network constructor in the web.
@ditman
Copy link
Member Author

ditman commented Jun 4, 2020

Thanks for the super fast review @cyanglaz, I'll merge this as soon as it goes green!

@ditman ditman merged commit 20d8ad2 into flutter:master Jun 5, 2020
@ditman ditman deleted the image-picker-web-example branch June 5, 2020 01:09
EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
@ditman @EdwinRomelta
[image_picker] Add web support to the example app. (flutter#2816)
521dcce
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
@ditman @jorgefspereira
[image_picker] Add web support to the example app. (flutter#2816)
a25fca4
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
@ditman
[image_picker] Add web support to the example app. (flutter#2816)
bfce5a7
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ditman @cyanglaz @googlebot