-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[shared_preferences_linux] Add support for Linux #2836
[shared_preferences_linux] Add support for Linux #2836
Conversation
I haven't worked out how to run The example program compiles and runs in Linux. |
packages/shared_preferences/shared_preferences/lib/shared_preferences.dart
Outdated
Show resolved
Hide resolved
packages/shared_preferences/shared_preferences/lib/shared_preferences.dart
Outdated
Show resolved
Hide resolved
packages/shared_preferences/shared_preferences_linux/lib/shared_preferences_linux.dart
Outdated
Show resolved
Hide resolved
Hm, https://github.com/flutter/plugins/blob/master/CONTRIBUTING.md#integration-tests should work. That's what the CI scripts are doing. But the Linux CI run passed, so it looks like it's in good shape. |
…ill be done once shared_preferences_linux is published
Note I updated the example to use shared_preferences_linux directly instead of shared_preferences. I think that makes sense based on the ordering you've suggested!? |
packages/shared_preferences/shared_preferences_linux/example/pubspec.yaml
Outdated
Show resolved
Hide resolved
…is not endorsed yet
packages/shared_preferences/shared_preferences_linux/test/shared_preferences_linux_test.dart
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll land this now, and publish it once post-submit is green.
It's live and ready to be endorsed! |
Adds shared_preferences support for Linux. Part of flutter/flutter#41720
Adds shared_preferences support for Linux. Part of flutter/flutter#41720
Adds shared_preferences support for Linux. Part of flutter/flutter#41720
Description
Adds shared_preferences support for Linux.
Related Issues
Part of flutter/flutter#41720
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?