Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] add option to set the background to transparent #2895

Closed

Conversation

crizant
Copy link

@crizant crizant commented Jul 24, 2020

Regarding this issue:
flutter/flutter#29300

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@crizant crizant force-pushed the webview-transparent-background branch from 84b1815 to 69b5562 Compare July 24, 2020 05:00
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@crizant crizant force-pushed the webview-transparent-background branch from 69b5562 to 19e8b5e Compare July 24, 2020 05:18
@crizant crizant changed the title [webview] add option to set the background to transparent [webview_flutter] add option to set the background to transparent Jul 24, 2020
@TheOneWithTheBraid
Copy link
Contributor

@real1900 Will this be merged soonly?

@crizant crizant force-pushed the webview-transparent-background branch from 19e8b5e to add3545 Compare October 8, 2020 05:49
@crizant crizant requested a review from amirh as a code owner October 8, 2020 05:49
@zhuoCreator
Copy link

Hi, when will this PR merge?

@crizant crizant force-pushed the webview-transparent-background branch from add3545 to 904657f Compare October 23, 2020 07:36
@rildexter
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@crizant
Copy link
Author

crizant commented Oct 24, 2020

@rildexter what do you mean? i have done it and @googlebot said "CLAs look good".

@scaraux
Copy link

scaraux commented Oct 29, 2020

Please this needs to be merged asap 🙏

@crizant crizant force-pushed the webview-transparent-background branch from 904657f to 9407b27 Compare December 3, 2020 12:49
@SalehHub
Copy link
Contributor

SalehHub commented Jan 9, 2021

Any plan on merging this one?

@volser
Copy link

volser commented Jan 10, 2021

@crizant can you resolve conflicts, please, maybe they finnaly will merge it

@crizant
Copy link
Author

crizant commented Jan 11, 2021

@crizant can you resolve conflicts, please, maybe they finnaly will merge it

I'm tired of rebasing again and again. I have switched to another plugin, take a look at here for more:

@stuartmorgan stuartmorgan added the p: webview_flutter Edits files for a webview_flutter plugin label Jan 29, 2021
@stuartmorgan stuartmorgan removed the request for review from amirh February 16, 2021 21:28
@stuartmorgan
Copy link
Contributor

Thanks for the submission! We’re currently working through a large backlog of PRs, and this will require non-trivial review, so it will take a little time before we’re able to review it. As explained in CONTRIBUTING.md, votes for the corresponding issue are the primary way we’re prioritizing non-trivial reviews; this is a fairly highly-rated issue, so we expect to get to this soon after completing the in-progress null-safety migrations.

This will need a test of the code in webview_flutter.dart (that it's sent to the interface); ideally there would native testing as well, but we need infrastructure plumbed up for that for webview_flutter still, and I don't think we need to gate this change on that.

We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.

@crizant
Copy link
Author

crizant commented Sep 23, 2021

Since #3431 is opened and somebody is handling it, it seems that I can take some rest.
I'm closing this merge request. Guys, please follow #3431 instead.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.