Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

ios camera takes advantage of NV12 pixelbuffer #2905

Closed

Conversation

cikelengfeng
Copy link

iOS takes advantage of 420v pixelbuffer

In order to make it more convenient for everyone to use the gain brought by this PR, I modified the camera plugin to enable it to output the pixelbuffer in NV12 format (of course, this is turned off by default)

Related Issues

flutter/flutter#31041

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@cikelengfeng cikelengfeng changed the title ios takes advantage of NV12 pixelbuffer ios camera takes advantage of NV12 pixelbuffer Aug 3, 2020
@danielroek
Copy link
Contributor

@cikelengfeng Would it be useful to have a option exposed to Dart where users are able to choose which videoFormat to use? e.g. a boolean use420Y, which defaults to false. Now users do not have the option to use it, as they would have to clone the camera plugin to change the line of code u added.

@mvanbeusekom
Copy link
Contributor

This feature is implemented in #3359, therefore closing this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants