Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[versions] increase package:platform constraint #2934

Merged
merged 1 commit into from
Aug 17, 2020
Merged

[versions] increase package:platform constraint #2934

merged 1 commit into from
Aug 17, 2020

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Aug 16, 2020 •
edited
Loading

Description

Fixes flutter/flutter#63441

package:platform required a breaking change in the behavior of FakePlatform in order to enable null safety, but there will be no other breaking changes in 3.X Since this does not affect path provider or local_auth, the pubspec constraint can be increased.

@jonahwilliams jonahwilliams marked this pull request as ready for review August 17, 2020 16:45
cyanglaz
cyanglaz approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@jonahwilliams jonahwilliams merged commit 0e46769 into flutter:master Aug 17, 2020
@jonahwilliams
Copy link
Member Author

I'm not sure what the publishing procedure is, but I'm happy to do that if someone gives me permissions :)

@jonahwilliams jonahwilliams deleted the roll_platform_version branch August 17, 2020 17:04
@cyanglaz
Copy link
Contributor

The publish process is described here: https://github.com/flutter/plugins/blob/master/CONTRIBUTING.md#the-release-process
You should already have permissions. Let me know if you don't have them. :)

@jonahwilliams
Copy link
Member Author

@cyanglaz :

Insufficient permissions to upload new versions of package `local_auth`.

pub finished with exit code 1

Publish failed. Exiting.

jarrodcolburn pushed a commit to jarrodcolburn/plugins that referenced this pull request Aug 20, 2020
@jonahwilliams @jarrodcolburn
[versions] increase package:platform constraint (flutter#2934)
de1413a 
package:platform required a breaking change in the behavior of FakePlatform in order to enable null safety, but there will be no other breaking changes in 3.X Since this does not affect path provider or local_auth, the pubspec constraint can be increased.
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
@jonahwilliams @jorgefspereira
[versions] increase package:platform constraint (flutter#2934)
9ebf643 
package:platform required a breaking change in the behavior of FakePlatform in order to enable null safety, but there will be no other breaking changes in 3.X Since this does not affect path provider or local_auth, the pubspec constraint can be increased.
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
@jonahwilliams
[versions] increase package:platform constraint (flutter#2934)
df3dd66 
package:platform required a breaking change in the behavior of FakePlatform in order to enable null safety, but there will be no other breaking changes in 3.X Since this does not affect path provider or local_auth, the pubspec constraint can be increased.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

@dnfield dnfield Awaiting requested review from dnfield

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[null-safety] migration of tests to null-safety is blocked by gallery dependency
3 participants
@jonahwilliams @cyanglaz @googlebot