-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[device_info] Port device_info to use platform interface #2942
Conversation
Hey @ditman , kindly have a look at this one. 😄 |
packages/device_info/device_info/example/test_driver/device_info_e2e.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's merge this once the tests pass!
Thank You Sir! |
Hey @ditman , if I were to add support for linux in |
@yash1200 I'm not a desktop expert. Maybe @stuartmorgan has a better idea. I'd say: start with the stats that you need for your app, and build up from there. |
I'm not sure there's really any way for me to answer that question; even with just two implementations (iOS and Android) there's almost nothing at all in common between the two, so it's hard to judge what is or is not in scope. Perhaps before extending this to N new platforms there should be a clearer articulation by the ecosystem team of what general criteria should be used to decide what is added to it. (This PR is probably not the place for that discussion though.) |
Filed flutter/flutter#64569 |
Description
In this PR, I have ported
device_info
to usedevice_info_platform_package
.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?