Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[device_info] Port device_info to use platform interface #2942

Merged
merged 3 commits into from
Aug 19, 2020
Merged

[device_info] Port device_info to use platform interface #2942

merged 3 commits into from
Aug 19, 2020

Conversation

yash1200
Copy link
Contributor

Description

In this PR, I have ported device_info to use device_info_platform_package .

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@yash1200
Copy link
Contributor Author

yash1200 commented Aug 18, 2020

Hey @ditman , kindly have a look at this one. 😄

@ditman ditman self-requested a review August 19, 2020 04:50
@ditman ditman self-requested a review August 19, 2020 18:43
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's merge this once the tests pass!

@yash1200
Copy link
Contributor Author

Thank You Sir!

@ditman ditman merged commit 0b156b2 into flutter:master Aug 19, 2020
@yash1200 yash1200 deleted the yash_device_info branch August 19, 2020 23:37
jarrodcolburn pushed a commit to jarrodcolburn/plugins that referenced this pull request Aug 20, 2020
@yash1200
Copy link
Contributor Author

Hey @ditman , if I were to add support for linux in device_info , then what are the necessary stats that I must include in it. Should I include all the stats which neofetch shows?

@ditman
Copy link
Member

ditman commented Aug 25, 2020

@yash1200 I'm not a desktop expert. Maybe @stuartmorgan has a better idea. I'd say: start with the stats that you need for your app, and build up from there.

@stuartmorgan
Copy link
Contributor

I'm not sure there's really any way for me to answer that question; even with just two implementations (iOS and Android) there's almost nothing at all in common between the two, so it's hard to judge what is or is not in scope. Perhaps before extending this to N new platforms there should be a clearer articulation by the ecosystem team of what general criteria should be used to decide what is added to it.

(This PR is probably not the place for that discussion though.)

@stuartmorgan
Copy link
Contributor

Filed flutter/flutter#64569

jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants