Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[battery] Updated README.md #2944

Merged
merged 1 commit into from
Aug 25, 2020
Merged

[battery] Updated README.md #2944

merged 1 commit into from
Aug 25, 2020

Conversation

yash1200
Copy link
Contributor

Description

In this pr, I have changed battery variable to private variable as it was used as private variable in one of it's example.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@yash1200
Copy link
Contributor Author

@ditman Can you review this small change ? :)

ditman
ditman approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yash1200
Copy link
Contributor Author

Thanks :)

@ditman ditman self-assigned this Aug 20, 2020
@yash1200
Copy link
Contributor Author

I think this is ready to be resynched with master.

@ditman
Copy link
Member

ditman commented Aug 25, 2020

I'm merging this, this is only a docs change, and everything is green.

@ditman ditman merged commit 420c28a into flutter:master Aug 25, 2020
@jiahaog jiahaog mentioned this pull request Aug 26, 2020
Merged
dnfield pushed a commit that referenced this pull request Aug 26, 2020
@jiahaog @yash1200
Rebase previous commits (#2966)
f8f666f 
* [battery] Fixed typo in README.md (#2944)

* [integration_test] Remove debugging statement (#2963)

Co-authored-by: Yash Johri <yashjohri1200@gmail.com>
@yash1200 yash1200 deleted the yash_battery branch August 26, 2020 16:19
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
@jiahaog @yash1200 @jorgefspereira
Rebase previous commits (flutter#2966)
9b9262e 
* [battery] Fixed typo in README.md (flutter#2944)

* [integration_test] Remove debugging statement (flutter#2963)

Co-authored-by: Yash Johri <yashjohri1200@gmail.com>
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
@jiahaog @yash1200
Rebase previous commits (flutter#2966)
5c17c70 
* [battery] Fixed typo in README.md (flutter#2944)

* [integration_test] Remove debugging statement (flutter#2963)

Co-authored-by: Yash Johri <yashjohri1200@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ditman ditman ditman approved these changes

@amirh amirh Awaiting requested review from amirh

@matthew-carroll matthew-carroll Awaiting requested review from matthew-carroll

Assignees

@ditman ditman

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yash1200 @ditman @googlebot