Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher]Added webOnlyWindowName parameter to launch() #2979

Merged
merged 6 commits into from
Aug 28, 2020

Conversation

balvinderz
Copy link
Contributor

Description

Adds the ability to launch a url in same tab,new tab or launch the url in an iframe using webOnlyWindowName parameter

Related Issues

flutter/flutter#56867

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@balvinderz
Copy link
Contributor Author

@ditman 2nd pr

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need to merge this on red, to fix the current breakage in the repo (I shouldn't have published platform_interface 1.0.8 so soon)

@ditman ditman merged commit 7c49361 into flutter:master Aug 28, 2020
@ditman
Copy link
Member

ditman commented Aug 28, 2020

Merged with most of the checks passed, I'll keep an eye on post-submit checks and merge the new packages ASAP.

@ditman
Copy link
Member

ditman commented Aug 28, 2020

Both url_launcher and url_launcher_web have been published:

@LasseRosenow
Copy link

I get this exception since updating to url_launcher 5.5.1


Running Gradle task 'assembleDebug'...
../../../../AppData/Roaming/Pub/Cache/hosted/pub.dartlang.org/url_launcher-5.5.1/lib/url_launcher.dart:100:5: Error: No named parameter with the name 'webOnlyWindowName'.
    webOnlyWindowName: webOnlyWindowName,
    ^^^^^^^^^^^^^^^^^


FAILURE: Build failed with an exception.

* Where:
Script 'C:\src\flutter\packages\flutter_tools\gradle\flutter.gradle' line: 904

* What went wrong:
Execution failed for task ':app:compileFlutterBuildDebug'.
> Process 'command 'C:\src\flutter\bin\flutter.bat'' finished with non-zero exit value 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 46s
Exception: Gradle task assembleDebug failed with exit code 1

@cyanglaz
Copy link
Contributor

@lazylazyllama Maybe try flutter clean?

@LasseRosenow
Copy link

Running pub upgrade fixed it. It seems the platform_interface plugin was still on 1.0.7

@balvinderz balvinderz deleted the web_only_window_name branch August 29, 2020 03:58
@stuartmorgan
Copy link
Contributor

This is using a parameter added in 1.0.8 of the interface package, but didn't rev the dependency in pubspec, which is still 1.0.4. This PR should have set that to 1.0.8.

KevinTheGray added a commit to KevinTheGray/plugins that referenced this pull request Aug 31, 2020
* master:
  [url_launcher, url_launcher_web]Added webOnlyWindowName parameter to launch()  (flutter#2979)
  [battery_platform_interface] Introduce package. (flutter#2975)
  [url_launcher_platform_interface] Add webOnlyWindowName parameter to launch() (flutter#2974)
  [share] Add sharing file support (android & ios) (flutter#970)
  [integration_test] add support to get timeline (flutter#2947)
  [battery] Moved battery to its own subdir (flutter#2969)
  [integration_test] Fix channel name for iOS, docs (flutter#2972)
  [integration_test] Show stack trace of widget test errors on the platform side (flutter#2967)
  [video_player] Fix `setWithOthers` test (flutter#2970)
  [video_player_platform_interface] fix `setMixIWithOthers` test channel (flutter#2968)
  Add README instructions for enablePendingPurchases (flutter#2921)
  Rebase previous commits (flutter#2966)
  Avoid walleye 26
  Updating documentation to use isEmpty check. (flutter#2955)
  [integration_test] Minor cleanup (flutter#2956)
  [path_provider, video_player] Tweak pubspecs to pass bulk analysis. (flutter#2959)
  [android_intent] fix platform package dep (flutter#2948)
  [shared_preferences_linux] update `file` package dep version to be compatible with framework (flutter#2950)
@ditman
Copy link
Member

ditman commented Aug 31, 2020

5.5.2 should address the issue. Thanks @stuartmorgan for letting me know about the flutter issue!

jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants