Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] Fix Android unit test. #2985

Merged
merged 2 commits into from
Sep 1, 2020

Conversation

xster
Copy link
Member

@xster xster commented Aug 31, 2020

Fix test broken by flutter/engine@15f5696#diff-599e1d64442183ead768757cca6805c3L154.

Turns out it was never needed for the test anyway.

Copy link
Contributor

@nturgut nturgut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look!

@ditman ditman changed the title Fix google maps test [google_maps_flutter] Fix Android unit test. Aug 31, 2020
@ditman
Copy link
Member

ditman commented Aug 31, 2020

I'll merge this as soon as all the checks pass. Will have to merge with submit-queue on red, since this PR is fixing the current breakage of the tree.

@ditman
Copy link
Member

ditman commented Aug 31, 2020

Also /cc @cyanglaz FYI (you wrote the original version of the test).

Remove unused imports.
@ditman ditman merged commit 90924b5 into flutter:master Sep 1, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants