Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[video_player_platform_interface] Add cookie support (1/3) #3136

Closed

Conversation

jaysephjw
Copy link

@jaysephjw jaysephjw commented Oct 11, 2020

Part 1 of #2882 - see main description there.

  • Add a cookies field for DataSourceType.network requests.
  • Re-run pigeon. Most diffs are formatting changes from that - I have left them in to avoid hand editing generated code. I used the same pigeon version.

@stuartmorgan
Copy link
Contributor

Thanks for the submission! We’re currently working through a large backlog of PRs, and this will require non-trivial review, so it will take some time before we’re able to review it. As explained in CONTRIBUTING.md, votes for the corresponding issue are the primary way we’re prioritizing non-trivial reviews, so we encourage anyone interested in this PR to vote for the corresponding issue.

@jaysephjw
Copy link
Author

Achieved in #3671!

@jaysephjw jaysephjw closed this Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants