Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter_web][url_launcher_web][video_player_web] Remove custom analysis options #3230

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.1.0+6

* Remove the analysis_options.yaml file and comply with the flutter/plugins analysis_options.

## 0.1.0+5

* Update `package:google_maps` to `^3.4.5`.
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,7 @@ gmaps.MarkerOptions _markerOptionsFromMarker(
// already encoded in the iconConfig[1]

icon = gmaps.Icon()
// ignore: undefined_prefixed_name
..url = ui.webOnlyAssetManager.getAssetUrl(iconConfig[1]);

// iconConfig[3] may contain the [width, height] of the image, if passed!
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ class GoogleMapController {
// use it to create the [gmaps.GMap] in the `init()` method of this class.
_div = DivElement()..id = _getViewType(mapId);

// ignore: undefined_prefixed_name
ui.platformViewRegistry.registerViewFactory(
_getViewType(mapId),
(int viewId) => _div,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: google_maps_flutter_web
description: Web platform implementation of google_maps_flutter
homepage: https://github.com/flutter/plugins/tree/master/packages/google_maps_flutter
version: 0.1.0+5
version: 0.1.0+6

flutter:
plugin:
Expand Down
4 changes: 4 additions & 0 deletions packages/url_launcher/url_launcher_web/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 0.1.5+1

- Remove the analysis_options.yaml file and comply with the flutter/plugins analysis_options.

# 0.1.5

- Added the web implementation of the Link widget.
Expand Down
10 changes: 0 additions & 10 deletions packages/url_launcher/url_launcher_web/analysis_options.yaml

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ class UrlLauncherPlugin extends UrlLauncherPlatform {
/// Registers this class as the default instance of [UrlLauncherPlatform].
static void registerWith(Registrar registrar) {
UrlLauncherPlatform.instance = UrlLauncherPlugin();
// ignore: undefined_prefixed_name
ui.platformViewRegistry.registerViewFactory(linkViewType, linkViewFactory);
}

Expand Down
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher_web/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ homepage: https://github.com/flutter/plugins/tree/master/packages/url_launcher/u
# 0.1.y+z is compatible with 1.0.0, if you land a breaking change bump
# the version to 2.0.0.
# See more details: https://github.com/flutter/flutter/wiki/Package-migration-to-1.0.0
version: 0.1.5
version: 0.1.5+1

flutter:
plugin:
Expand Down
4 changes: 4 additions & 0 deletions packages/video_player/video_player_web/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.1.4+1

* Remove the analysis_options.yaml file and comply with the flutter/plugins analysis_options.

## 0.1.4

* Added option to set the video playback speed on the video controller.
Expand Down
10 changes: 0 additions & 10 deletions packages/video_player/video_player_web/analysis_options.yaml

This file was deleted.

2 changes: 1 addition & 1 deletion packages/video_player/video_player_web/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ homepage: https://github.com/flutter/plugins/tree/master/packages/video_player/v
# 0.1.y+z is compatible with 1.0.0, if you land a breaking change bump
# the version to 2.0.0.
# See more details: https://github.com/flutter/flutter/wiki/Package-migration-to-1.0.0
version: 0.1.4
version: 0.1.4+1

flutter:
plugin:
Expand Down
3 changes: 0 additions & 3 deletions script/incremental_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ fi
# TODO(mklim): Remove everything from this list. https://github.com/flutter/flutter/issues/45440
CUSTOM_ANALYSIS_PLUGINS=(
"camera"
"video_player/video_player_web"
"google_maps_flutter/google_maps_flutter_web"
"url_launcher/url_launcher_web"
)
# Comma-separated string of the list above
readonly CUSTOM_FLAG=$(IFS=, ; echo "${CUSTOM_ANALYSIS_PLUGINS[*]}")
Expand Down