Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Fixes crash with using inner camera on some Android devices. #3419

Merged
merged 2 commits into from
Jan 14, 2021
Merged

[camera] Fixes crash with using inner camera on some Android devices. #3419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a336dfe
[camera] Fix crashes on some Android devices
najeira Jan 14, 2021
49a55f4
[camera] Updates pubspec.yaml and CHANGELOG.md
najeira Jan 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/camera/camera/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.7.0+3

* Fixes crash with using inner camera on some Android devices.

## 0.7.0+2

* Improved error feedback by differentiating between uninitialized and disposed camera controllers.
Expand Down
3 changes: 2 additions & 1 deletion packages/camera/camera/android/src/main/java/io/flutter/plugins/camera/Camera.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,6 @@ public void open(String imageFormatGroup) throws CameraAccessException {
public void onOpened(@NonNull CameraDevice device) {
cameraDevice = device;
try {
cameraRegions = new CameraRegions(getRegionBoundaries());
startPreview();
dartMessenger.sendCameraInitializedEvent(
previewSize.getWidth(),
Expand Down Expand Up @@ -300,6 +299,8 @@ private void createCaptureSession(
}
}

cameraRegions = new CameraRegions(getRegionBoundaries());

// Prepare the callback
CameraCaptureSession.StateCallback callback =
new CameraCaptureSession.StateCallback() {
Expand Down
2 changes: 1 addition & 1 deletion packages/camera/camera/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: camera
description: A Flutter plugin for getting information about and controlling the
camera on Android and iOS. Supports previewing the camera feed, capturing images, capturing video,
and streaming image buffers to dart.
version: 0.7.0+2
version: 0.7.0+3
homepage: https://github.com/flutter/plugins/tree/master/packages/camera/camera

dependencies:
Expand Down