Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Bump ffi dependencies #3540

Merged
merged 2 commits into from
Feb 12, 2021
Merged

Bump ffi dependencies #3540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4639339
Update to FFI 1.0
Feb 12, 2021
53246bb
Bump CHANGELOG
Feb 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/path_provider/path_provider_windows/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 0.1.0-nullsafety.3

* Bump ffi dependency to 1.0.0
* Bump win32 dependency to 2.0.0-nullsafety.12

## 0.1.0-nullsafety.2

* Bump ffi dependency to 0.3.0-nullsafety.1
Expand Down
10 changes: 5 additions & 5 deletions packages/path_provider/path_provider_windows/lib/src/path_provider_windows_real.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class VersionInfoQuerier {
if (VerQueryValue(versionInfo, keyPath, valueAddress, length) == 0) {
return null;
}
return valueAddress.value.unpackString(length.value);
return valueAddress.value.toDartString();
} finally {
calloc.free(keyPath);
calloc.free(length);
Expand Down Expand Up @@ -64,7 +64,7 @@ class PathProviderWindows extends PathProviderPlatform {
final error = GetLastError();
throw WindowsException(error);
} else {
path = buffer.unpackString(length);
path = buffer.toDartString();

// GetTempPath adds a trailing backslash, but SHGetKnownFolderPath does
// not. Strip off trailing backslash for consistency with other methods
Expand Down Expand Up @@ -132,7 +132,7 @@ class PathProviderWindows extends PathProviderPlatform {
}
}

final path = pathPtrPtr.value.unpackString(MAX_PATH);
final path = pathPtrPtr.value.toDartString();
return Future.value(path);
} finally {
calloc.free(pathPtrPtr);
Expand Down Expand Up @@ -183,8 +183,8 @@ class PathProviderWindows extends PathProviderPlatform {

// If there was no product name, use the executable name.
if (productName == null) {
productName = path.basenameWithoutExtension(
moduleNameBuffer.unpackString(moduleNameLength));
productName =
path.basenameWithoutExtension(moduleNameBuffer.toDartString());
}

return companyName != null
Expand Down
6 changes: 3 additions & 3 deletions packages/path_provider/path_provider_windows/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: path_provider_windows
description: Windows implementation of the path_provider plugin
homepage: https://github.com/flutter/plugins/tree/master/packages/path_provider/path_provider_windows
version: 0.1.0-nullsafety.2
version: 0.1.0-nullsafety.3

flutter:
plugin:
Expand All @@ -16,8 +16,8 @@ dependencies:
path: ^1.8.0-nullsafety.3
flutter:
sdk: flutter
ffi: '>=0.3.0-nullsafety.1 <2.0.0'
win32: ^2.0.0-nullsafety.10
ffi: ^1.0.0
win32: ^2.0.0-nullsafety.12

dev_dependencies:
flutter_test:
Expand Down