-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[camera] Stable release for null safety. #3641
Conversation
# Because mockito >=5.0.0 depends on analyzer ^1.0.0 which depends on crypto ^3.0.0 | ||
# every version of flutter_driver from sdk depends on crypto 2.1.5. | ||
mockito: ^5.0.0-nullsafety.7 | ||
plugin_platform_interface: ^2.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think since this is the last plugin to be published as stable, this will work. Let's see how our bots handle it.
(Ideally we can now sweep the repo to make everything require 2.0.0 instead of a range that includes a non-nullable version.)
@stuartmorgan thanks for the feedback. I have gone through all your comments and made the necessary adjustments. Could you have another look please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more nits, but otherwise looks good.
pedantic: ^1.8.0 | ||
integration_test: | ||
path: ../../../integration_test | ||
test: any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this to resolve a conflict? We don't usually use any
unless we have to; I would expect 1.16.0
(or 1.16.3 if you need Fake
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was actually a mistake on my end. I added this dependency because I was receiving a CI failure with the dependencies related to the integration_test
in combination with running in NNBD. I started comparing with the video_player
plugin and noticed that this dependency was included this way and decided to give that a try. Reading back in the Discord channel I realised that we shouldn't run integration_tests in NNBD mode (and add the // @dart = 2.9
instruction to the top of the file). Unfortunately I forgot to remove this dependency which I did this time ;).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* master: Adopt Xcode 12 for podspec lints (flutter#3653) Run static analyzer during xctest (flutter#3667) [google_maps_flutter_web] update min flutter sdk version to 1.20.0 (flutter#3662) [image_picker] Run CocoaPods iOS tests in RunnerUITests target (flutter#3663) [webview_flutter] Run CocoaPods iOS tests in RunnerUITests target (flutter#3664) [device_info] Enable NNBD for unit test (flutter#3658) remove unused plugin (flutter#3661) [android_intent] move unit test to nullsafety (flutter#3659) [url_launcher] Migrate unit tests to NNBD (flutter#3657) [share] Migrate unit tests to null-safety. (flutter#3660) [connectivity_for_web] Migration to null-safety. (flutter#3652) [camera] Stable release for null safety. (flutter#3641) [in_app_purchase] fix plugin version (flutter#3654) Move plugin tool tests over (flutter#3606) [in_app_purchase] migrate playing billing library to v3 (flutter#3636) Update plugin_platform_interface min version (flutter#3650) # Conflicts: # packages/webview_flutter/CHANGELOG.md # packages/webview_flutter/example/ios/Runner.xcodeproj/project.pbxproj
Stable NNBD release for the camera package.
With this PR I also migrated the example App to sound null safe. Note that I didn't update the dev-dependency on
mockito: ^5.0.0-nullsafety.7
since the stable version causes a conflict with the current flutter_driver dependency. I have marked the dependency in the pubspec.yaml with a# TODO(mvanbeusekom)
comment to remind me to remove it when the conflict is resolved.Conflict details:
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
[shared_preferences]
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.