This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[path_provider] Switch macOS to an internal method channel #4547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
Dec 2, 2021
|
|
||
| @override | ||
| Future<String?> getDownloadsPath() { | ||
| return methodChannel.invokeMethod<String>('getDownloadsDirectory'); |
There was a problem hiding this comment.
Might be worthwhile adding a note that the mix match of names is intentional.
There was a problem hiding this comment.
There's no reason method channels need to parallel platform interfaces, so I don't really consider it a mismatch; all that is expected (and required) to match is the Dart and native endpoints.
(Longer term this should probably be replaced with a single method+enum using Pigeon, to more closely mirror the OS API, but I just wanted to do the initial cleanup of using an internal method channel for now.)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 3, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 3, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
) Eliminates the path_provider_macos reliance on the default, shared method channel implementation, in favor of an in-package implementation. Now that it's trivial to do so, also moves the creation of directories when necessary to the Dart side, and unit tests it there. Part of flutter/flutter#94224
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
) Eliminates the path_provider_macos reliance on the default, shared method channel implementation, in favor of an in-package implementation. Now that it's trivial to do so, also moves the creation of directories when necessary to the Dart side, and unit tests it there. Part of flutter/flutter#94224
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates the path_provider_macos reliance on the default, shared method channel implementation, in favor of an in-package implementation.
Now that it's trivial to do so, also moves the creation of directories when necessary to the Dart side, and unit tests it there.
Part of flutter/flutter#94224
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).