Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] Add a backgroundColor option to the webview #4584

Merged
merged 2 commits into from
Dec 7, 2021
Merged

[webview_flutter] Add a backgroundColor option to the webview #4584

merged 2 commits into from
Dec 7, 2021

Conversation

e-adrien
Copy link
Contributor

@e-adrien e-adrien commented Dec 6, 2021

This PR add an option to set the background color of the webview.

Original PR :
#3431

Fixes flutter/flutter#29300
Fixes flutter/flutter#37697

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to master. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot changed the base branch from master to main December 6, 2021 23:17
@github-actions github-actions bot added the p: webview_flutter Edits files for a webview_flutter plugin label Dec 6, 2021
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mvanbeusekom for second review

Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one very small nit (p.s. thank you for all the work on this).

Comment on lines 290 to 294
/// The background color of the webview.
///
/// When null the platform's webview default background color is used.
///
/// By default `backgroundColor` is null.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: documentation can be improved a little bit (similar to the Android specific version).

Suggested change
/// The background color of the webview.
///
/// When null the platform's webview default background color is used.
///
/// By default `backgroundColor` is null.
/// The background color of the [WebView].
///
/// When `null` the platform's webview default background color is used. By
/// default [backgroundColor] is `null`.

@e-adrien
Copy link
Contributor Author

e-adrien commented Dec 7, 2021

Done.

It's nothing compare to the amount of time we save thanks to Flutter. 😅
Thank you very much.

@mvanbeusekom mvanbeusekom added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Dec 7, 2021
@fluttergithubbot fluttergithubbot merged commit 0c5357f into flutter:main Dec 7, 2021
@stuartmorgan
Copy link
Contributor

Something strange happened here; somehow this was redirected from master to main, but I'm not seeing it on main either. I tried opening a new copy of the PR to merge to master, but it gets reset to main again.

It looks like there's some kind of infra issue here? @godofredoc

@stuartmorgan
Copy link
Contributor

Filed flutter/flutter#94790 to try to figure out what's going on here so we can get this landed to the correct branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p: webview_flutter Edits files for a webview_flutter plugin waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants