-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[webview_flutter] Add a backgroundColor option to the webview #4584
Conversation
This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to master. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@mvanbeusekom for second review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one very small nit (p.s. thank you for all the work on this).
/// The background color of the webview. | ||
/// | ||
/// When null the platform's webview default background color is used. | ||
/// | ||
/// By default `backgroundColor` is null. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: documentation can be improved a little bit (similar to the Android specific version).
/// The background color of the webview. | |
/// | |
/// When null the platform's webview default background color is used. | |
/// | |
/// By default `backgroundColor` is null. | |
/// The background color of the [WebView]. | |
/// | |
/// When `null` the platform's webview default background color is used. By | |
/// default [backgroundColor] is `null`. |
Done. It's nothing compare to the amount of time we save thanks to Flutter. 😅 |
Something strange happened here; somehow this was redirected from It looks like there's some kind of infra issue here? @godofredoc |
Filed flutter/flutter#94790 to try to figure out what's going on here so we can get this landed to the correct branch. |
This PR add an option to set the background color of the webview.
Original PR :
#3431
Fixes flutter/flutter#29300
Fixes flutter/flutter#37697
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.