This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Revert "[camera]Fix crash due to calling engine APIs from background thread" #4629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
Hm, not sure why |
|
@jmagman did you edit the PR description after you created this PR? |
I didn't have |
|
@jmagman FYI I had similar issue and tried resetting and recommitting the original commit and it worked. |
hellohuanlin
approved these changes
Dec 20, 2021
Hm, let me try that... |
|
Let me just reopen this. |
|
Worked this time: #4630 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4608
I don't think this is the best way to solve this, let's revert until @stuartmorgan and I can review.
No version change:
That PR didn't bump the version, so there's no publication issue.