Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Ignore body_might_complete_normally_catch_error violation #5957

Merged
merged 4 commits into from
Jun 15, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/camera/camera_platform_interface/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## NEXT

* Ignores unnecessary import warnings in preparation for [upcoming Flutter changes](https://github.com/flutter/flutter/pull/104231).
* Ignores missing return warnings in preparation for [upcoming analysis changse](https://github.com/flutter/flutter/issues/105750).
srawlins marked this conversation as resolved.
Show resolved Hide resolved

## 2.2.0

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,12 @@ class MethodChannelCamera extends CameraPlatform {
'cameraId': cameraId,
'imageFormatGroup': imageFormatGroup.name(),
},
).catchError(
)
// TODO(srawlins): This should return a value of the future's type. This
// will fail upcoming analysis checks with
// https://github.com/flutter/flutter/issues/105750.
// ignore: body_might_complete_normally_catch_error
.catchError(
(Object error, StackTrace stackTrace) {
if (error is! PlatformException) {
throw error;
Expand Down