Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter_wkwebview] Copies iOS implementation of webview_flutter from v4_webview #6852

Merged
merged 6 commits into from
Dec 16, 2022

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Dec 15, 2022

  • Copies webview_flutter_wkwebview from v4_webview branch.
  • Updates pubspec.yaml, CHANGELOG.md.
    • The README just points to webview_flutter, so no changes were made.
  • Exclude package from build-all-packages test.

Part of flutter/flutter#94051

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added p: webview_flutter Edits files for a webview_flutter plugin platform-ios labels Dec 15, 2022
@bparrishMines bparrishMines changed the title Ios release [webview_flutter_wkwebview] Copies Android implementation of webview_flutter from v4_webview Dec 15, 2022
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metadata changes LGTM, all the merged parts RSLGTM

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 15, 2022
@auto-submit
Copy link

auto-submit bot commented Dec 15, 2022

auto label is removed for flutter/plugins, pr: 6852, Failed to merge pr#: 6852 with Pull request could not be merged: Pull Request is not mergeable.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 15, 2022
@bparrishMines bparrishMines changed the title [webview_flutter_wkwebview] Copies Android implementation of webview_flutter from v4_webview [webview_flutter_wkwebview] Copies iOS implementation of webview_flutter from v4_webview Dec 15, 2022
@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 16, 2022
@auto-submit auto-submit bot merged commit cbcf507 into flutter:main Dec 16, 2022
@bparrishMines bparrishMines deleted the ios_release branch December 16, 2022 04:38
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 16, 2022
* 6c0df1a0c Roll Flutter (stable) from b8f7f1f to 135454a (6 revisions) (flutter/plugins#6850)

* 6bba84334 [webview_flutter_android] Copies Android implementation of webview_flutter from v4_webview (flutter/plugins#6851)

* cbcf50726 [webview_flutter_wkwebview] Copies iOS implementation of webview_flutter from v4_webview (flutter/plugins#6852)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…#117213)

* 6c0df1a0c Roll Flutter (stable) from b8f7f1f to 135454a (6 revisions) (flutter/plugins#6850)

* 6bba84334 [webview_flutter_android] Copies Android implementation of webview_flutter from v4_webview (flutter/plugins#6851)

* cbcf50726 [webview_flutter_wkwebview] Copies iOS implementation of webview_flutter from v4_webview (flutter/plugins#6852)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
…ter from v4_webview (flutter#6852)

* new ios release

* version bump

* add breaking change change

* update excludes file

* fix lints and add to changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: webview_flutter Edits files for a webview_flutter plugin platform-ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants