Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[video_player]add http headers option when loading network data source #953

Closed

Conversation

rcunning
Copy link

@rcunning rcunning commented Dec 1, 2018

I added optional request headers to VideoPlayerController.network contructor for video_player plugin. I did not see an obvious place to create a test for these changes, but happy to do so if you would like. I did manually test these changes on iOS and Android emulator.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@rcunning
Copy link
Author

rcunning commented Dec 1, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Dec 1, 2018
@cbenhagen
Copy link
Contributor

Hi, thank you for trying to finally fix flutter/flutter#16466. There is already a very similar PR open here #897.

The problem seems to be the usage of AVURLAssetHTTPHeaderFieldsKey. I can't tell if the usage of this private API would really get an app rejected. Can you try to get more information on this?

@cyanglaz cyanglaz changed the title add http headers option when loading network data source [video_player]add http headers option when loading network data source Feb 22, 2019
@JohnGalt1717

This comment was marked as abuse.

@ezamagni
Copy link

I really need this feature for my project. Unfortunately this PR seems abandoned. Any chance in getting it resumed?

@rcunning
Copy link
Author

I really need this feature for my project. Unfortunately this PR seems abandoned. Any chance in getting it resumed?

See comments in feature request flutter/flutter#16466 and a similar pr #897

If I were you and you really need it, fork the repo, apply one of the prs (will have to update a little I am sure), and move on. You will have to merge in changes from the main repo though whenever you want the latest (see https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/merging-an-upstream-repository-into-your-fork).

@troyanskiy
Copy link

Can someone resolve the conflicts and merge it. That is very useful feature!
Thank you!

@stuartmorgan
Copy link
Contributor

Closing, as there is already #897 which addresses the same issue; let's consolidate discussion there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants