Skip to content

Commit

Permalink
Updated per @anderdobo review
Browse files Browse the repository at this point in the history
  • Loading branch information
atsansone committed Sep 29, 2023
1 parent 33750ea commit 79492f6
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 46 deletions.
1 change: 1 addition & 0 deletions _config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ appnow:
vscode: '1.81.1'
android_studio: '2022.3.1 (Giraffe)'
android_sdk: '33.0.0'
intellij: '2023.1'
powershell: 5.0
xcode: '15'
ios: '17'
Expand Down
37 changes: 16 additions & 21 deletions src/_includes/docs/install/flutter-doctor-success.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,47 +2,42 @@ Running flutter doctor...
Doctor summary (to see all details, run flutter doctor -v):
[] Flutter (Channel stable, {{site.appnow.flutter}}, on {{os}} A.B chipset, locale en)
{% if os=='Windows' -%}
[] Windows version (Installed version of Windows is version 10 or higher)
[] Windows version (Installed version of Windows is version 10 or higher)
{% endif -%}
{% if target=='mobile' -%}
[] Android toolchain - develop for Android devices (Android SDK version {{site.appnow.android_sdk}})
[] Android toolchain - develop for Android devices (Android SDK version {{site.appnow.android_sdk}})
{% else -%}
[] Android toolchain - develop for Android devices
Unable to locate Android SDK.
Install Android Studio from: https://developer.android.com/studio/index.html
On first launch it will assist you in installing the Android SDK components.
(or visit https://developer.android.com/studio/install#windows for detailed instructions).
If the Android SDK has been installed to a custom location, please use
`flutter config --android-sdk` to update to that location.
[!] Android toolchain - develop for Android devices
{% endif -%}
{% if target=='web' -%}
[] Chrome - develop for the web
[] Chrome - develop for the web
{% else -%}
[!] Chrome - develop for the web
{% endif -%}
{% if os=='macOS' -%}
[] Xcode - develop for iOS and macOS (Xcode {{site.appnow.xcode}})
[] Xcode - develop for iOS and macOS (Xcode {{site.appnow.xcode}})
{% endif -%}
{% if os=='Windows' -%}
{% if target=='desktop' -%}
[] Visual Studio - develop Windows apps (version 2022)
[] Visual Studio - develop Windows apps (version 2022)
{% else -%}
[] Visual Studio - develop Windows apps
Visual Studio not installed; this is necessary to develop Windows apps.
Download at https://visualstudio.microsoft.com/downloads/.
Please install the Desktop development with C++ workload, including all of its default components
[!] Visual Studio - develop Windows apps
{% endif -%}
{% endif -%}
{% if target=='mobile' -%}
[] Android Studio (version {{site.appnow.android_studio}})
[] Android Studio (version {{site.appnow.android_studio}})
{% else -%}
[] Android Studio not found; download from https://developer.android.com/studio/index.html
(or visit https://developer.android.com/studio/install#windows for detailed instructions).
[!] Android Studio (not installed)
[!] IntelliJ IDEA Community Edition (version {{site.appnow.intellij}})
{% endif -%}
[] VS Code (version {{site.appnow.vscode}})
[] Connected device (1 available)
[] Network resources

{% if target=='desktop' -%}
• 2 issues found.
! Doctor found issues in 4 categories.
{% elsif target=='mobile' -%}
• 1 issue found.
! Doctor found issues in 3 categories.
{% elsif target=='web' -%}
! Doctor found issues in 4 categories.
{% endif -%}
25 changes: 0 additions & 25 deletions src/_includes/docs/install/flutter-doctor.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,31 +20,6 @@
{% assign prompt1='$' %}
{% assign prompt2='$' %}
{% endif -%}
{% if target == 'web' %}
{% assign limiter = '--no-enable-linux-desktop --no-enable-macos-desktop --no-enable-windows-desktop --no-enable-android --no-enable-ios' %}
{% capture limitresponse -%}
Setting "enable-linux-desktop" value to "false".
Setting "enable-macos-desktop" value to "false".
Setting "enable-windows-desktop" value to "false".
Setting "enable-android" value to "false".
Setting "enable-ios" value to "false".
{% endcapture %}
{% elsif target == 'mobile' %}
{% assign limiter = '--no-enable-web --no-enable-linux-desktop --no-enable-macos-desktop --no-enable-windows-desktop' %}
{% capture limitresponse -%}
Setting "enable-web" value to "false".
Setting "enable-linux-desktop" value to "false".
Setting "enable-macos-desktop" value to "false".
Setting "enable-windows-desktop" value to "false".
{% endcapture %}
{% elsif target == 'desktop' %}
{% assign limiter = '--no-enable-web --no-enable-android --no-enable-ios' %}
{% capture limitresponse -%}
Setting "enable-web" value to "false".
Setting "enable-android" value to "false".
Setting "enable-ios" value to "false".
{% endcapture %}
{% endif %}

### Run Flutter Doctor

Expand Down
3 changes: 3 additions & 0 deletions src/get-started/install/windows/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ target-list: [Desktop, Mobile, Web]
{% endif -%}
</span>
<span class="text-muted text-nowrap">{{target}}</span>
{% if icon == 'mobile' -%}
Recommended
{% endif -%}
</header>
</div>
</a>
Expand Down

0 comments on commit 79492f6

Please sign in to comment.