Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate deploy pipeline to Cloud Build #10098

Closed
khanhnwin opened this issue Jan 29, 2024 · 0 comments · Fixed by #10104
Closed

Migrate deploy pipeline to Cloud Build #10098

khanhnwin opened this issue Jan 29, 2024 · 0 comments · Fixed by #10104
Assignees
@parlough
Labels
e1-hours Effort: < 8 hrs infra.structure Relates to the tools that create docs.flutter.dev p1-high Major but not urgent concern: Resolve in months. Update each month.

Comments

@khanhnwin
Copy link
Contributor

Describe the problem

Most DevRel repos that deploy to Firebase Hosting are using Cloud Build for the deploy pipeline to bypass the need for SA key rotations. The deploy action for flutter/website wasn't included because it doesn't currently use a SA key.

Regardless, we should migrate the flutter/website deploy action to Cloud Build too for standardization.

Expected fix

dos.flutter.dev (flutter/website repo) should be deployed using Cloud Build instead of GitHub Actions.

On which platform(s) did you experience this issue?

No response

Additional context

#10096
@khanhnwin khanhnwin added the infra.structure Relates to the tools that create docs.flutter.dev label Jan 29, 2024
@parlough parlough added p1-high Major but not urgent concern: Resolve in months. Update each month. e1-hours Effort: < 8 hrs labels Jan 29, 2024
@parlough parlough mentioned this issue Jan 31, 2024
Merged
parlough added a commit that referenced this issue Feb 1, 2024
@parlough @khanhnwin
Migrate deploy workflow to Cloud Build (#10104)
26e9b19 
Fixes #10098

---------

Co-authored-by: Khanh Nguyen <khanhnwin@gmail.com>
atsansone pushed a commit to atsansone/website that referenced this issue Feb 15, 2024
@parlough @khanhnwin @atsansone
Migrate deploy workflow to Cloud Build (flutter#10104)
479a987 
Fixes flutter#10098

---------

Co-authored-by: Khanh Nguyen <khanhnwin@gmail.com>
@parlough parlough mentioned this issue Apr 4, 2024
Closed
atsansone pushed a commit to atsansone/website that referenced this issue Apr 5, 2024
@parlough @khanhnwin @atsansone
Migrate deploy workflow to Cloud Build (flutter#10104)
91bbed9 
Fixes flutter#10098

---------

Co-authored-by: Khanh Nguyen <khanhnwin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parlough parlough

Labels
e1-hours Effort: < 8 hrs infra.structure Relates to the tools that create docs.flutter.dev p1-high Major but not urgent concern: Resolve in months. Update each month.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate deploy workflow to Cloud Build flutter/website
3 participants
@khanhnwin @parlough @drewroengoogle