Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace CachedNetworkImage with Image.network on 'Work with cached images' page #8324

Closed
bryanoltman opened this issue Mar 1, 2023 · 3 comments · Fixed by #9923
Closed

Replace CachedNetworkImage with Image.network on 'Work with cached images' page #8324

bryanoltman opened this issue Mar 1, 2023 · 3 comments · Fixed by #9923
Assignees
@domesticmouse
Labels
e1-hours Effort: < 8 hrs from.page-issue Reported in a reader-filed concern p1-high Major but not urgent concern: Resolve in months. Update each month. t.networking Relates to networking within an app t.ui.assets Relates to adding or changing images, videos, and other assets

Comments

@bryanoltman
Copy link

bryanoltman commented Mar 1, 2023 •
edited
Loading

Page URL

https://docs.flutter.dev/cookbook/images/cached-images/

Page source

https://github.com/flutter/website/tree/main/src/cookbook/images/cached-images.md

Describe the problem

This page recommends the CachedNetworkImage package, which I believe to be unnecessary now that the Image.network constructor exists and "All network images are cached regardless of HTTP headers".

Expected fix

Recommend the built-in Image.network constructor instead of a third-party package.

Additional context

No response
@danagbemava-nc danagbemava-nc added st.triage.triage-team Triage team reviewing and categorizing the issue p2-medium Necessary but not urgent concern. Resolve when possible. e1-hours Effort: < 8 hrs and removed st.triage.triage-team Triage team reviewing and categorizing the issue labels Mar 2, 2023
@atsansone atsansone added from.page-issue Reported in a reader-filed concern t.ui.assets Relates to adding or changing images, videos, and other assets labels May 22, 2023
@atsansone atsansone changed the title [PAGE ISSUE]: 'Work with cached images' Replace CachedNetworkImage with Image.network on 'Work with cached images' page May 30, 2023
@atsansone atsansone added ltw-triage t.networking Relates to networking within an app labels May 30, 2023
This was referenced May 30, 2023
Closed
Closed
@atsansone atsansone added p1-high Major but not urgent concern: Resolve in months. Update each month. and removed p2-medium Necessary but not urgent concern. Resolve when possible. labels May 30, 2023
@atsansone
Copy link
Contributor

Escalated to P1 as it was found repeatedly over 4 years. This should get extra attention.

@domesticmouse
Copy link
Contributor

domesticmouse commented Dec 12, 2023 •
edited
Loading

Proposed actions:

  1. Update https://github.com/flutter/website/blob/main/src/cookbook/images/network-image.md to remove the Image.network doesn't cache language
  2. Remove https://github.com/flutter/website/tree/main/src/cookbook/images/cached-images.md

sg?

@domesticmouse domesticmouse self-assigned this Dec 12, 2023
@domesticmouse domesticmouse mentioned this issue Dec 13, 2023
Merged
@domesticmouse
Copy link
Contributor

#9923 is blocked until we get confirmation that Image.network caches retrieved images on all six platforms.

sfshaza2 pushed a commit that referenced this issue Feb 12, 2024
@domesticmouse @parlough
Drop cached_network_image package (#9923)
daf8991 
Drop references to `cached_network_image` package because the
[`Image.network`](https://api.flutter.dev/flutter/widgets/Image/Image.network.html)
named constructor caches images.

Closes #8324

---------

Co-authored-by: Parker Lougheed <parlough@gmail.com>
atsansone pushed a commit to atsansone/website that referenced this issue Feb 15, 2024
@domesticmouse @parlough @atsansone
Drop cached_network_image package (flutter#9923)
a7b9fc6 
Drop references to `cached_network_image` package because the
[`Image.network`](https://api.flutter.dev/flutter/widgets/Image/Image.network.html)
named constructor caches images.

Closes flutter#8324

---------

Co-authored-by: Parker Lougheed <parlough@gmail.com>
atsansone pushed a commit to atsansone/website that referenced this issue Apr 5, 2024
@domesticmouse @parlough @atsansone
Drop cached_network_image package (flutter#9923)
8edbc12 
Drop references to `cached_network_image` package because the
[`Image.network`](https://api.flutter.dev/flutter/widgets/Image/Image.network.html)
named constructor caches images.

Closes flutter#8324

---------

Co-authored-by: Parker Lougheed <parlough@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domesticmouse domesticmouse

Labels
e1-hours Effort: < 8 hrs from.page-issue Reported in a reader-filed concern p1-high Major but not urgent concern: Resolve in months. Update each month. t.networking Relates to networking within an app t.ui.assets Relates to adding or changing images, videos, and other assets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop cached_network_image package domesticmouse/website
5 participants
@domesticmouse @bryanoltman @atsansone @johnpryan @danagbemava-nc