Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty links #9524

Closed
Tracked by #9495
atsansone opened this issue Oct 16, 2023 · 1 comment · Fixed by #10336
Closed
Tracked by #9495

Fix empty links #9524

atsansone opened this issue Oct 16, 2023 · 1 comment · Fixed by #10336
Assignees
Labels
e2-days Effort: < 5 days p2-medium Necessary but not urgent concern. Resolve when possible. st.blocked Issue cannot continue until another action completes t.a11y Relates to an accessibility concern

Comments

@atsansone
Copy link
Contributor

atsansone commented Oct 16, 2023

Location anchors for the headings default to empty links. Consider remedies from this StackOverflow article.

https://amberwilson.co.uk/blog/are-your-anchor-links-accessible/

@atsansone atsansone added t.a11y Relates to an accessibility concern st.triage.ltw p1-high Major but not urgent concern: Resolve in months. Update each month. e2-days Effort: < 5 days labels Oct 16, 2023
@atsansone atsansone self-assigned this Oct 16, 2023
@atsansone atsansone assigned parlough and unassigned atsansone Oct 26, 2023
@parlough parlough added p2-medium Necessary but not urgent concern. Resolve when possible. p1-high Major but not urgent concern: Resolve in months. Update each month. st.blocked Issue cannot continue until another action completes and removed p1-high Major but not urgent concern: Resolve in months. Update each month. p2-medium Necessary but not urgent concern. Resolve when possible. labels Nov 4, 2023
@parlough
Copy link
Member

parlough commented Nov 4, 2023

We rely on an external plugin for this and they don't allow configuration of this. The replacement I'm working on for dart.dev already has this fixed and improved, so I'd like to wait for that to land. Let me know if this needs to land immediately though.

@atsansone atsansone added p2-medium Necessary but not urgent concern. Resolve when possible. and removed p1-high Major but not urgent concern: Resolve in months. Update each month. labels Apr 3, 2024
parlough added a commit that referenced this issue Apr 4, 2024
atsansone pushed a commit to atsansone/website that referenced this issue Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2-days Effort: < 5 days p2-medium Necessary but not urgent concern. Resolve when possible. st.blocked Issue cannot continue until another action completes t.a11y Relates to an accessibility concern
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants