Update parallax-scrolling.md #10144
Closed
Update parallax-scrolling.md #10144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afradahsan
requested review from
sfshaza2,
atsansone,
parlough,
domesticmouse and
MaryaBelanger
as code owners
|
/gcbrun |
|
Visit the preview URL for this PR (updated for commit a4eb557): |
|
Some checks were not successful Is there something that i should resolve from my side? |
|
This change requires changing the related sample. As the related sample compiles, maybe the issue is a better excerpt could be found? Or maybe the sample need refactoring? |
|
@afradahsan, until you can fix the broken code excerpt, we can't land this. |
|
Superceded by #10180. Thanks for filing, @afradahsan. Closing. |
atsansone
pushed a commit
to atsansone/website
that referenced
this pull request
Apr 5, 2024
This extends PR flutter#10144 (which I will close), by removing several extraneous right curly brackets from Dart samples. It also ran the refresh-code-excepts tool, which updated 3 code excerpts. Fixes flutter#10138 Thanks, @afradadahsan, for filing the original PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10138
In the Parallax scrolling page, in one of the code, there are some unwanted brackets as mentioned in the docs.
I just fixed that and is creating the request.