Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styles for fixes and closer alignment to dart.dev #10265

Merged
merged 10 commits into from
Mar 13, 2024

Conversation

parlough
Copy link
Member

@parlough parlough commented Mar 10, 2024

This results in closer alignment to dart.dev and includes the improvements of:

  • Improved accessibility of text in asides/admonitions with greatly increased contrast
  • Less distracting right TOC styles
  • The inline TOC has a background to visually differentiate it from nearby content

Contributes to #10203

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Mar 11, 2024

Visit the preview URL for this PR (updated for commit 0d83657):

https://flutter-docs-prod--pr10265-misc-update-styles-94eriyag.web.app

@parlough parlough marked this pull request as ready for review March 11, 2024 13:34
@parlough parlough added the review.tech Awaiting Technical Review label Mar 11, 2024
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 merged commit b66d96b into main Mar 13, 2024
10 checks passed
@sfshaza2 sfshaza2 deleted the misc/update-styles branch March 13, 2024 19:27
@sfshaza2 sfshaza2 removed the review.tech Awaiting Technical Review label Mar 14, 2024
atsansone pushed a commit to atsansone/website that referenced this pull request Mar 18, 2024
This results in closer alignment to dart.dev and includes the
improvements of:

- Improved accessibility of text in asides/admonitions with greatly
increased contrast
- Less distracting right TOC styles
- The inline TOC has a background to visually differentiate it from
nearby content

Contributes to flutter#10203

---------

Co-authored-by: Brett Morgan <brettmorgan@google.com>
atsansone pushed a commit to atsansone/website that referenced this pull request Apr 5, 2024
This results in closer alignment to dart.dev and includes the
improvements of:

- Improved accessibility of text in asides/admonitions with greatly
increased contrast
- Less distracting right TOC styles
- The inline TOC has a background to visually differentiate it from
nearby content

Contributes to flutter#10203

---------

Co-authored-by: Brett Morgan <brettmorgan@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants