-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update styles for fixes and closer alignment to dart.dev #10265
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visit the preview URL for this PR (updated for commit 0d83657): https://flutter-docs-prod--pr10265-misc-update-styles-94eriyag.web.app |
parlough
requested review from
khanhnwin,
sfshaza2,
atsansone,
domesticmouse and
MaryaBelanger
as code owners
March 11, 2024 13:34
domesticmouse
approved these changes
Mar 11, 2024
sfshaza2
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
atsansone
pushed a commit
to atsansone/website
that referenced
this pull request
Mar 18, 2024
This results in closer alignment to dart.dev and includes the improvements of: - Improved accessibility of text in asides/admonitions with greatly increased contrast - Less distracting right TOC styles - The inline TOC has a background to visually differentiate it from nearby content Contributes to flutter#10203 --------- Co-authored-by: Brett Morgan <brettmorgan@google.com>
atsansone
pushed a commit
to atsansone/website
that referenced
this pull request
Apr 5, 2024
This results in closer alignment to dart.dev and includes the improvements of: - Improved accessibility of text in asides/admonitions with greatly increased contrast - Less distracting right TOC styles - The inline TOC has a background to visually differentiate it from nearby content Contributes to flutter#10203 --------- Co-authored-by: Brett Morgan <brettmorgan@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This results in closer alignment to dart.dev and includes the improvements of:
Contributes to #10203