Update Java and Gradle versions in android-java-gradle-migration-guid… #11272
Conversation
…e.md This pull request enhances the android-java-gradle-migration-guide.md file by updating it with the latest Java version (21) and its compatible Gradle version (8.5). The guide now includes detailed instructions on how to check the JDK version using flutter upgrade and flutter doctor --verbose. These improvements are designed to provide a more generalized solution, making it applicable and beneficial for a wider range of developers. By incorporating these updates, we aim to ensure that the guide remains relevant and useful for those working on Android projects with Flutter, offering clear and up-to-date information that can help prevent compatibility issues and streamline the setup process.
KarthiDreamr
requested review from
sfshaza2,
parlough and
a team
as code owners
There was a problem hiding this comment.
@KarthiDreamr, this is great! Thanks for updating the page. We don't really attempt to keep the breaking changes pages up to date but, obviously, this is very useful.
Some images need to be removed and replaced (with the new non-flamingo names), or just renamed. I'm not sure if the old images are still accurate.
I see no point in (yet) running the CI, since it will fail because of the missing images.
Anyway, thanks again and let me know when this PR is ready for another review!
src/content/release/breaking-changes/android-java-gradle-migration-guide.md
Outdated
Show resolved
Hide resolved
|
|
||
| The terminal output for this error is | ||
| similar to the following: | ||
|  |
There was a problem hiding this comment.
This file does not appear to exist and it's not in this PR.
src/content/release/breaking-changes/android-java-gradle-migration-guide.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/android-java-gradle-migration-guide.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/android-java-gradle-migration-guide.md
Outdated
Show resolved
Hide resolved
|
|
||
| 1. In Android Studio, open the `android` folder. | ||
| This should bring up the following dialog: | ||
|
|
||
| {:width="50%"} | ||
| {:width="50%"} |
There was a problem hiding this comment.
This image file also does not exist. Either replace the flamingo images with newer, renamed images or rename the flamingo image, whichever is correct. (These are in the repo under /src/content/assets/images/docs/releaseguide/.)
|
|
||
| 1. Follow the guided workflow to update Gradle. | ||
|
|
||
| {:width="85%"} | ||
| {:width="85%"} |
There was a problem hiding this comment.
Ditto - file isn't there. Also, the "{:width=} was done because the original images overflowed the screen. have you confirmed that this is no longer necessary?
…tion-guide.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
…tion-guide.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
…tion-guide.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
…tion-guide.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Description:
This pull request enhances the
android-java-gradle-migration-guide.mdfile by:flutter upgradeandflutter doctor --verbose.These improvements: