Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the 'Photo filter carousel' recipe #11453

Closed
wants to merge 1 commit into from

Conversation

antfitch
Copy link
Contributor

@antfitch antfitch commented Dec 2, 2024

Description of what this PR is changing or adding, and why:

Remove a recipe that references non-Flutter code.

Issues fixed by this PR (if any):

Fixes #8204

PRs or commits this PR depends on (if any):

n/a

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@antfitch antfitch requested review from sfshaza2, parlough and a team as code owners December 2, 2024 21:07
@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 442e7e1):

https://flutter-docs-prod--pr11453-fw-8204-remove-recipe-ygynfeuc.web.app

@antfitch antfitch self-assigned this Dec 2, 2024
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks great except for a couple things:

Thanks, @antfitch!

@parlough
Copy link
Member

parlough commented Dec 3, 2024

You shouldn't need to delete this from the index file. It's my understanding that this file is autogenerated. Right, @parlough? Or is that no longer the case?

This index file is still manually built, I believe maybe because the automatic order based on name isn't exactly what we wanted. So it still needs to be removed.

@antfitch antfitch closed this Dec 4, 2024
@antfitch antfitch deleted the FW_8204_remove_recipe branch December 4, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After deprecation period, remove this recipe from website
4 participants