-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FFI plugin docs #7111
FFI plugin docs #7111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, I just have some minor comments/questions.
Also do we have a FFI plugin sample we could point to?
Co-authored-by: Parker Lougheed <parlough@gmail.com>
I'm afraid not currently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, looks good to me :)
You may have to reopen/update the PR once @khanhnwin incorporates the WIP website changes.
Co-authored-by: Parker Lougheed <parlough@gmail.com>
Fix for stable build is part of #7113 . Once that's merged in, we can merge from main into this branch and it should pass the build. |
@khanhnwin can you help ensuring this gets merged when ready? It's nearly midnight here, so I'm heading out shortly... |
@mit-mit Will do! |
Merged! Thanks @mit-mit! |
Fixes #7073