chore: add note to README.md for Git line endings on Windows
#7217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZaLiTHkA
requested review from
sfshaza2,
khanhnwin,
domesticmouse and
johnpryan
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
FWIW, this could possibly have been used to close #6201, but it's already closed.. so.. 🖖🏼 |
domesticmouse
requested changes
Jun 2, 2022
sfshaza2
reviewed
Jun 2, 2022
sfshaza2
reviewed
Jun 2, 2022
sfshaza2
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what this PR is changing or adding, and why:
Updates the
REAMD.mdfile with a note for Windows users, instructing them to set Git'sautocrlfconfiguration option toinputbefore initializing the submodules.This ensures that line endings are handled correctly by Git before any Bash commands are executed inside the aforementioned submodules.
Issues fixed by this PR (if any):
Presubmit checklist