Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the “Performance FAQ” content error #8815

Merged
merged 4 commits into from
Jun 2, 2023
Merged

Fix the “Performance FAQ” content error #8815

merged 4 commits into from
Jun 2, 2023

Conversation

AmosHuKe
Copy link
Contributor

@AmosHuKe AmosHuKe commented Jun 1, 2023 •
edited by atsansone
Loading

Closes #8814

Presubmit checklist

atsansone
atsansone reviewed Jun 1, 2023
View reviewed changes
src/perf/faq.md Outdated Show resolved Hide resolved
atsansone
atsansone approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % one suggestion. Thanks!

@atsansone atsansone added the st.RFM.% Ready to merge or land with minor changes. No further review needed. label Jun 1, 2023
@AmosHuKe AmosHuKe requested a review from khanhnwin as a code owner June 2, 2023 01:03
@AmosHuKe AmosHuKe requested a review from atsansone June 2, 2023 01:16
@AmosHuKe AmosHuKe mentioned this pull request Jun 2, 2023
Merged
sfshaza2
sfshaza2 approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for this correction!

@sfshaza2 sfshaza2 merged commit 45f62eb into flutter:main Jun 2, 2023
@AmosHuKe AmosHuKe deleted the pr-1 branch June 2, 2023 17:36
@sfshaza2 sfshaza2 removed the st.RFM.% Ready to merge or land with minor changes. No further review needed. label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@parlough parlough Awaiting requested review from parlough parlough is a code owner

@khanhnwin khanhnwin Awaiting requested review from khanhnwin

@atsansone atsansone Awaiting requested review from atsansone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix typo for IntelliJ performance tool on 'Performance FAQ' page
3 participants
@AmosHuKe @atsansone @sfshaza2