Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /ui exception for mini-toc generation #9164

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Add /ui exception for mini-toc generation #9164

merged 3 commits into from
Jul 31, 2023

Conversation

parlough
Copy link
Member

@parlough parlough commented Jul 28, 2023

This allows index pages linked to from the breadcrumbs to be generated properly, such as the text index page. They were empty since the generation didn't account for /ui having multiple entries in the sidenav.

Before: https://docs.flutter.dev/ui/design/text

After: https://flutter-docs-prod--pr9164-fix-9156-yw9b52uw.web.app/ui/design/text

@parlough parlough added the review.copy Awaiting Copy Review label Jul 28, 2023
@github-actions
Copy link

github-actions bot commented Jul 28, 2023

Visit the preview URL for this PR (updated for commit 4a24809):

https://flutter-docs-prod--pr9164-fix-9156-yw9b52uw.web.app

(expires Fri, 11 Aug 2023 20:37:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d5ba327eec813901cac8396c4f458b02288624ab

@parlough parlough marked this pull request as ready for review July 28, 2023 20:26
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 removed the review.copy Awaiting Copy Review label Jul 31, 2023
Copy link
Contributor

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit.

@atsansone atsansone added the st.RFM.% Ready to merge or land with minor changes. No further review needed. label Jul 31, 2023
@parlough parlough removed the st.RFM.% Ready to merge or land with minor changes. No further review needed. label Jul 31, 2023
@parlough parlough merged commit 9ef9389 into main Jul 31, 2023
10 checks passed
@parlough parlough deleted the fix/9156 branch July 31, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants