-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /ui exception for mini-toc generation #9164
Conversation
Visit the preview URL for this PR (updated for commit 4a24809): https://flutter-docs-prod--pr9164-fix-9156-yw9b52uw.web.app (expires Fri, 11 Aug 2023 20:37:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d5ba327eec813901cac8396c4f458b02288624ab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one nit.
This allows index pages linked to from the breadcrumbs to be generated properly, such as the text index page. They were empty since the generation didn't account for
/ui
having multiple entries in the sidenav.Before: https://docs.flutter.dev/ui/design/text
After: https://flutter-docs-prod--pr9164-fix-9156-yw9b52uw.web.app/ui/design/text