Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to Linux Install from @wednesdei #9442

Merged
merged 12 commits into from
Oct 6, 2023
Merged

Fixes to Linux Install from @wednesdei #9442

merged 12 commits into from
Oct 6, 2023

Conversation

atsansone
Copy link
Contributor

Description of what this PR is changing or adding, and why:

This replaces

Fixes #8025
Fixes #2131
Fixes #6499

Presubmit checklist

Chris M and others added 3 commits September 21, 2023 17:15
This commit introduces several significant enhancements to the Linux installation guide for Flutter. Key changes include:

1. Expanded 'System Requirements' section with clearer, more concise language.
2. Added a new 'Understanding Linux Commands' section to familiarize users with common Linux commands used throughout the installation process.
3. Included a new section on 'Installing Snap on Ubuntu,' guiding users through the process of installing and using Snap on their Ubuntu systems.
4. Revamped the 'Flutter Installation', 'Android Studio Setup', and 'Chrome Setup' sections to provide more detailed, step-by-step instructions.
5. Incorporated a comprehensive 'Glossary' at the end of the document, providing definitions for key terms and commands.

The goal of these changes is to make the installation guide more accessible, user-friendly, and informative for users of all experience levels.
@github-actions
Copy link

github-actions bot commented Sep 22, 2023

Visit the preview URL for this PR (updated for commit c7c59c4):

https://flutter-docs-prod--pr9442-patch-1-ym8g17ow.web.app

(expires Fri, 13 Oct 2023 04:42:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d5ba327eec813901cac8396c4f458b02288624ab

@atsansone atsansone assigned domesticmouse and unassigned parlough Oct 5, 2023
@@ -2,129 +2,98 @@

{% include docs/china-notice.md %}

On Linux, you have two ways you can install Flutter.
Install Flutter on Linux using one of the following two methods.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter on Linux sounds odd to my ears. Flutter for Linux?


[(loading...)](#){:.download-latest-link-{{os}}.btn.btn-primary}
If you don't have or can't use `snapd`, follow these steps to install Flutter.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you aren't using snapd ?

src/get-started/install/linux.md Show resolved Hide resolved
src/get-started/install/linux.md Outdated Show resolved Hide resolved
src/get-started/install/linux.md Outdated Show resolved Hide resolved
Once you have snapd, you can
[install Flutter using the Snap Store][],
or at the command line:
After you install `snapd`, install Flutter from the Snap Store or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link to the snap store listing still seems useful here.

src/get-started/install/_get-sdk-linux.md Outdated Show resolved Hide resolved
src/get-started/install/_get-sdk-linux.md Outdated Show resolved Hide resolved
src/get-started/install/_get-sdk-linux.md Outdated Show resolved Hide resolved
Run the following command to see if there are any
dependencies you need to install to complete the setup
(for verbose output, add the `-v` flag):
For verbose output, add the `-v` flag:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This doesn't provide enough information to the reader why they would want to do this. Will it help them debug the listed issues, etc?

Once you have installed any missing dependencies,
run the `flutter doctor` command again to verify
that you've set everything up correctly.
After installing any missing dependencies,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous text also discussed "tasks to perform", but the changes lose that. It would be good to still add that clarification since flutter doctor isn't just about dependencies.

src/get-started/install/_get-sdk-linux.md Outdated Show resolved Hide resolved
@parlough parlough assigned atsansone and unassigned domesticmouse Oct 5, 2023
@parlough parlough added st.RFM.% Ready to merge or land with minor changes. No further review needed. and removed review.copy Awaiting Copy Review labels Oct 5, 2023
@atsansone atsansone merged commit 7db1f7c into main Oct 6, 2023
10 checks passed
@atsansone atsansone deleted the patch-1 branch October 6, 2023 05:08
atsansone added a commit to atsansone/website that referenced this pull request Oct 9, 2023
_Description of what this PR is changing or adding, and why:_

This replaces 
* flutter#9082
* flutter#9089

Fixes flutter#8025
Fixes flutter#2131
Fixes flutter#6499

## Presubmit checklist

- [ ] This PR doesn’t contain automatically generated corrections
(Grammarly or similar).
- [ ] This PR follows the [Google Developer Documentation Style
Guidelines](https://developers.google.com/style) — for example, it
doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person).
- [ ] This PR uses [semantic line
breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks)
of 80 characters or fewer.

---------

Co-authored-by: Chris M <44120439+wednesdei@users.noreply.github.com>
Co-authored-by: Brett Morgan <brettmorgan@google.com>
Co-authored-by: Parker Lougheed <parlough@gmail.com>
atsansone added a commit to atsansone/website that referenced this pull request Oct 13, 2023
_Description of what this PR is changing or adding, and why:_

This replaces 
* flutter#9082
* flutter#9089

Fixes flutter#8025
Fixes flutter#2131
Fixes flutter#6499

## Presubmit checklist

- [ ] This PR doesn’t contain automatically generated corrections
(Grammarly or similar).
- [ ] This PR follows the [Google Developer Documentation Style
Guidelines](https://developers.google.com/style) — for example, it
doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person).
- [ ] This PR uses [semantic line
breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks)
of 80 characters or fewer.

---------

Co-authored-by: Chris M <44120439+wednesdei@users.noreply.github.com>
Co-authored-by: Brett Morgan <brettmorgan@google.com>
Co-authored-by: Parker Lougheed <parlough@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
st.RFM.% Ready to merge or land with minor changes. No further review needed.
Projects
None yet
3 participants