Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed new 'Dive in to DevTools' video #9483

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

parlough
Copy link
Member

@parlough parlough commented Oct 5, 2023

@parlough parlough added the review.copy Awaiting Copy Review label Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Visit the preview URL for this PR (updated for commit 9b4c4f9):

https://flutter-docs-prod--pr9483-feature-new-devtools-oeee2b4v.web.app

(expires Thu, 12 Oct 2023 19:19:36 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d5ba327eec813901cac8396c4f458b02288624ab

Copy link
Contributor

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a title tag to the iframe for a11y.

@parlough
Copy link
Member Author

parlough commented Oct 5, 2023

Add a title tag to the iframe for a11y.

It already had one, but I went ahead and expanded it with some extra details. Perhaps a little repetitive, but that's fine. Thanks!

@johnpryan
Copy link
Contributor

LGTM, thank you @parlough!

@atsansone atsansone merged commit ce3cbef into main Oct 5, 2023
@atsansone atsansone deleted the feature/new-devtools-video branch October 5, 2023 19:58
@sfshaza2 sfshaza2 removed the review.copy Awaiting Copy Review label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants