Added note to horizontal list recipe #9960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atsansone
requested review from
parlough,
domesticmouse and
MaryaBelanger
as code owners
|
Visit the preview URL for this PR (updated for commit 0f6e3a2): |
khanhnwin
reviewed
Dec 22, 2023
| @@ -47,6 +47,13 @@ ListView( | |||
|
|
|||
| ## Interactive example | |||
|
|
|||
| {{site.alert.note}} | |||
| **Desktop and web only:** This example works in the browser and on the desktop. However, as it scrolls on the horizontal axis (left to right or right to left), hold <kbd>Shift</kbd> when hovering your mouse pointer over the list to scroll it. | |||
There was a problem hiding this comment.
Nit: I would specify <kbd>Shift</kbd> + scroll wheel on web or desktop. mouse click + drag scroll won't work unless we specify scrollbehavior per: https://docs.flutter.dev/release/breaking-changes/default-scroll-behavior-drag
There was a problem hiding this comment.
Also:
- Please use line breaks as this line is over 80 chars.
- Use "site.alert.secondary", instead of "site.alert.note". The secondary macro uses "Desktop and web only" as the header.
sfshaza2
approved these changes
Dec 22, 2023
| @@ -47,6 +47,13 @@ ListView( | |||
|
|
|||
| ## Interactive example | |||
|
|
|||
| {{site.alert.note}} | |||
| **Desktop and web only:** This example works in the browser and on the desktop. However, as it scrolls on the horizontal axis (left to right or right to left), hold <kbd>Shift</kbd> when hovering your mouse pointer over the list to scroll it. | |||
There was a problem hiding this comment.
Also:
- Please use line breaks as this line is over 80 chars.
- Use "site.alert.secondary", instead of "site.alert.note". The secondary macro uses "Desktop and web only" as the header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9378