Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust the conversion type of viewport.offset to ScrollPosition #41

Merged
merged 1 commit into from
Aug 25, 2023
Merged

fix: adjust the conversion type of viewport.offset to ScrollPosition #41

merged 1 commit into from
Aug 25, 2023

Conversation

LiuDongCai
Copy link
Contributor

@LiuDongCai LiuDongCai commented Aug 25, 2023 •
edited
Loading

针对 issue #40 做了修复

@LiuDongCai LiuDongCai changed the title fix: #40 fix: adjust the conversion type of viewport.offset to ScrollPosition Aug 25, 2023
@LinXunFeng LinXunFeng self-requested a review August 25, 2023 14:45
LinXunFeng
LinXunFeng approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@LinXunFeng LinXunFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinXunFeng LinXunFeng merged commit b614b9c into fluttercandies:main Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinXunFeng LinXunFeng LinXunFeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LiuDongCai @LinXunFeng