Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Handle exceptions after all flows #216

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Conversation

AlexV525
Copy link
Member

No description provided.

@AlexV525 AlexV525 marked this pull request as ready for review October 26, 2023 06:16
@AlexV525 AlexV525 merged commit dd11736 into main Oct 28, 2023
5 checks passed
@AlexV525 AlexV525 deleted the fix/handle-error-at-the-bottom branch October 28, 2023 03:57
Copy link

@sydneyagcaoili sydneyagcaoili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a merge issue

Comment on lines -145 to -149
isSavingEntity = false;
if (mounted) {
setState(() {});
}
return;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha! This is a very bad change... The "return" is omitted @AlexV525 . So the issue about duplicate saving entity has happened again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants