fix: on iOS, check http status when downloaded finished #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
I observed that when downloading an
invalidresource, it returns a success in [URLSession: downloadTask: didFinishDownloadingToURL:], then it returns a failure in [URLSession: task: didCompleteWithError:], finally callback twice. The expectation should be to only return a failure.Why:
In [URLSession: downloadTask: didFinishDownloadingToURL:] , the http status code of the invalid resource's downloadTask is 404 or other failed code, and the location exists invalid temporary file which will be copied to the destinationURL. The copy result is succeeded, so it returns a success.
In [URLSession: task: didCompleteWithError:], invalid resource task status code is also 404 or other failed code, so it returns a failure.
Solution:
When 404 or other failed http status code appears, ignore it in [URLSession: downloadTask: didFinishDownloadingToURL:], but process it in [URLSession: task: didCompleteWithError:], ensure to only return a failure.