Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow nullable content-type #966

Merged
merged 7 commits into from
Jul 25, 2024

Conversation

ryzizub
Copy link
Contributor

@ryzizub ryzizub commented Jul 17, 2024

On Android when source had null content-type, the request fails and throws exception. It's unexpected behavior since there is nothing wrong with downloaded file.

Proposing to resolve #935 and resolve #936

@ryzizub ryzizub requested a review from salmaahhmed as a code owner July 17, 2024 19:12
@ryzizub
Copy link
Contributor Author

ryzizub commented Jul 17, 2024

@ryzizub
Copy link
Contributor Author

ryzizub commented Jul 22, 2024

@bartekpacia would you have a time to review this? :)

bartekpacia
bartekpacia previously approved these changes Jul 24, 2024
Copy link
Collaborator

@bartekpacia bartekpacia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, thanks for contributing!

@ryzizub
Copy link
Contributor Author

ryzizub commented Jul 25, 2024

Thank you for approval @bartekpacia! There was one kotlin lint issue, i fixed that, it needs just approval again 😄

@bartekpacia bartekpacia merged commit a1cc3e5 into fluttercommunity:master Jul 25, 2024
1 check passed
@bartekpacia
Copy link
Collaborator

Hey, thanks!

I'm at work now but I'll make a release later today.

@bartekpacia
Copy link
Collaborator

released in v1.11.8

@ryzizub
Copy link
Contributor Author

ryzizub commented Jul 25, 2024

@bartekpacia thank you!

wxuonline pushed a commit to wxuonline/flutter_downloader that referenced this pull request Nov 13, 2024
* feat: allow empty content-type on android

* feat: add nullable places for content type

* feat: add nullable mimeType do worker

* fix: add unknown type

* fix: add unknown type

* chore: fix lint issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants