-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Simplify import_sorter command #76
Conversation
Thanks @mrgnhnt96 for the PR, I think it's a good idea. But if the idea is to deprecate the
Then please force push your branch. That way, when we remove support for the |
Also, please add a third commit that removes references to |
@vkammerer once this is merged can we make a new release to pub.dev? |
@mrgnhnt96 Thanks for updating your PR. Could you look into why the |
I hadn't run import sorter lol, I just fixed it. It should pass now |
Thanks @mrgnhnt96 , that made the tests pass. I'll update the CHANGELOG and prepare a release to pub.dev |
@slightfoot We would like to make a new release to pub.dev. Would you be able to help us with it? |
This was finally published on pub.dev, under the version |
The current command to run import sorter is
With this change, the
:main
can be omitted, making the command more intuitiveThe
:main
command will not be removed to avoid breaking existing projects using import_sorter, but could be considered in the future. I've added a deprecated warning wheneverimport_sorter:main
is used.