Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(android_alarm_manager_plus): Add integration tests to alarm manager #1163

Conversation

LukeMoody01
Copy link
Contributor

Description

This PR adds integration tests to the android_alarm_manager_plus plugin and also adds these tests into the CI job on an android emulator.

Related Issues

This PR was previously opened under #1113 but had to be closed due to the PR no longer receiving commits from the head branch. Apologies for any inconvenience!

This PR addresses open issue #1103

@miquelbeltran could you link this to both the issue and the previous PR? I am not able to do that

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated the version in pubspec.yaml and CHANGELOG.md.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@miquelbeltran
Copy link
Member

this integration test is cursed :) I triggered a re-run of the job.

@LukeMoody01
Copy link
Contributor Author

I am not too sure why the callback test is failing in the job. I have tested it a lot locally, even creating new emulators to test on and it seems to work every time.

Any suggestions here would be great 🙂 (As I don't want to bombard the CI workflow by constantly pushing)

FYI @miquelbeltran

@miquelbeltran miquelbeltran changed the title feat: Add integration tests to alarm manager test(android_alarm_manager_plus): Add integration tests to alarm manager Oct 6, 2022
@miquelbeltran
Copy link
Member

Hey! Due to changes in our contributor guidelines, all PRs should now:

  • Have a title that follows the Conventional Commits format. e.g. feat(package_name)!: feature description
  • DO NOT modify the CHANGELOG.md or the version in the pubspec.yaml. This is going to be an automated process now.

We would ask you kindly to update the PR following these changes.

Thanks!

@miquelbeltran
Copy link
Member

The test definitely works locally but fails on CI. I think we can merge this, skip the test, and maybe someday go back to it.

@miquelbeltran miquelbeltran merged commit a1ad98f into fluttercommunity:main Oct 7, 2022
@miquelbeltran
Copy link
Member

Merged, thanks for the work @LukeMoody01 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants