-
-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(android_alarm_manager_plus): Add integration tests to alarm manager #1163
test(android_alarm_manager_plus): Add integration tests to alarm manager #1163
Conversation
…manager-plus-integration-tests
this integration test is cursed :) I triggered a re-run of the job. |
I am not too sure why the callback test is failing in the job. I have tested it a lot locally, even creating new emulators to test on and it seems to work every time. Any suggestions here would be great 🙂 (As I don't want to bombard the CI workflow by constantly pushing) FYI @miquelbeltran |
...ges/android_alarm_manager_plus/example/integration_test/android_alarm_manager_plus_test.dart
Show resolved
Hide resolved
Hey! Due to changes in our contributor guidelines, all PRs should now:
We would ask you kindly to update the PR following these changes. Thanks! |
The test definitely works locally but fails on CI. I think we can merge this, skip the test, and maybe someday go back to it. |
Merged, thanks for the work @LukeMoody01 ! |
Description
This PR adds integration tests to the android_alarm_manager_plus plugin and also adds these tests into the CI job on an android emulator.
Related Issues
This PR was previously opened under #1113 but had to be closed due to the PR no longer receiving commits from the head branch. Apologies for any inconvenience!
This PR addresses open issue #1103
@miquelbeltran could you link this to both the issue and the previous PR? I am not able to do that
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process.
pubspec.yaml
andCHANGELOG.md
.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?