feat(connectivity_plus): vpn support for android and linux #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
werainkhatri
force-pushed
the
connectivity-vpn-support
branch
from
a82472b
to
e3bbce5
Compare
|
Hey! Due to changes in our contributor guidelines, all PRs should now:
We would ask you kindly to update the PR following these changes. Thanks! |
werainkhatri
changed the title
done ✅
ya i got to know. i haven't modified these files, instead have added the checkbox stating i "haven't" done that. |
| @@ -56,12 +60,14 @@ private String getNetworkTypeLegacy() { | |||
| int type = info.getType(); | |||
| switch (type) { | |||
| case ConnectivityManager.TYPE_BLUETOOTH: | |||
| return "bluetooth"; | |||
| return CONNECTIVITY_BLUETOOTH; | |||
There was a problem hiding this comment.
Thanks for the improvement!
| completion(equals(ConnectivityResult.vpn)), | ||
| ); | ||
| }); | ||
|
|
There was a problem hiding this comment.
thanks for including tests!
miquelbeltran
approved these changes
Oct 7, 2022
miquelbeltran
added
Hacktoberfest
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds support for vpn as
ConnectivityResultto android and linux.for android - added it as there is a parameter for it, but haven't tested it on device as i don't have a VPN.
for linux - again, added it (taking the word of the issue author) but can't test it on device.
for macos / ios - i suppose they don't support knowing if a vpn is active as i wasn't able to find any doc supporting it. the APIs currently use don't have such a parameter.
for windows, web - tried searching for something, but not an expert so will leave it to them / a feature request to come up.
Related Issues
Fixes #1166
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process.
pubspec.yamlandCHANGELOG.md.///).flutter analyze) does not report any problems on my PR. (melos analyzefails locally but not related to my PR).Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?