ci(android_alarm_manager_plus): Add matrix of versions for integration tests #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbuberen
added
android_alarm_manager_plus
CI/CD
vbuberen
commented
Oct 9, 2022
| # Required for Android builds | ||
| - uses: actions/setup-java@v1 | ||
| # Required for Android builds | ||
| - uses: actions/setup-java@v2 |
There was a problem hiding this comment.
I experimented with removing this step as suggested in one of other PRs (because of https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md#java saying that such runners already have Java 11), but couldn't build the project due to missing Java 11. Thus, returned the step again.
vbuberen
commented
Oct 9, 2022
| with: | ||
| distribution: "temurin" |
There was a problem hiding this comment.
setup-java in v2 requires to specify the distribution type, thus, this addition.
vbuberen
commented
Oct 9, 2022
| api-level: 30 | ||
| arch: x86_64 | ||
| api-level: ${{ matrix.android-api-level }} | ||
| cores: 3 |
There was a problem hiding this comment.
MacOS runner has 3 cores available, while android-emulator-runner uses 2 by default. Specifying this value in effort to get higher performance.
miquelbeltran
approved these changes
Oct 9, 2022
Comment on lines
+44
to
+46
| strategy: | ||
| matrix: | ||
| android-api-level: [21, 26, 32] |
There was a problem hiding this comment.
Ohh that's cool, simpler than what I thought.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduced build matrix so tests run against multiple Android versions. It should help us to be sure that functionality of the plugin isn't broken by some change.
This PR has matrix only for Android alarm manager plus to get initial feedback. If other maintainers agree with suggested strategies in the next PR I will add similar changes for all plugins at once.
Initially I wanted to have 19 as a minimal version, but on 19 I saw such error:
So it seems that
integration_testdoesn't work well with old APIs.Mid version corresponds to Android O, which is something in the middle of the suggested range.
Max version is 32 as 33 acted strange during my tests on fork.
Checklist
CHANGELOG.mdnor thepubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).