-
-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(device_info_plus)!: two-package federated architecture #1228
Conversation
@miquelbeltran could you please check the web build (can easily be reproduced locally when running the example app in the browser)? |
I will take a look! |
@nohli seems that a conditional export did the trick! |
Nice, so my dev intuition was right 😄 Thanks for trying and fixing! ❤️ |
packages/device_info_plus/device_info_plus/macos/device_info_plus.podspec
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just a couple of questions
packages/device_info_plus/device_info_plus/macos/device_info_plus.podspec
Outdated
Show resolved
Hide resolved
packages/package_info_plus/package_info_plus/example/windows/runner/flutter_window.cpp
Show resolved
Hide resolved
I meant not just one line, but return info that was in |
…unfederate-device-info-plus
@miquelbeltran what about this issue? Should we say he can apply the changes to the latest architecture? (If we close it unmerged, does it still count towards hacktoberfest?) |
It is not.
If he agrees to do so. |
I believe it counts because it has the labels. |
If we want the change, we should communicate it in the other PR. Otherwise - if it's not updated - it can't be merged any more due to the new architecture. Btw. could you also give my 5 refactoring PRs the labels? |
I will just fix the merge conflict and go ahead with it, I still like the idea of removing the toMap method eventually |
Description
Refactor
device_info_plus
from the federated architecture to a platform interface and a package with all platform implementations.Related Issues
#1226
Checklist
CHANGELOG.md
nor thepubspec.yaml
files.flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).