Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(device_info_plus)!: two-package federated architecture #1228

Merged
merged 14 commits into from
Oct 13, 2022

Conversation

nohli
Copy link
Member

@nohli nohli commented Oct 13, 2022

Description

Refactor device_info_plus from the federated architecture to a platform interface and a package with all platform implementations.

Related Issues

#1226

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@nohli
Copy link
Member Author

nohli commented Oct 13, 2022

@miquelbeltran could you please check the web build (can easily be reproduced locally when running the example app in the browser)?
Do we need a conditional import/export of some sort for ffi/the windows implementation?

@miquelbeltran
Copy link
Member

I will take a look!

@miquelbeltran
Copy link
Member

@nohli seems that a conditional export did the trick!

@nohli
Copy link
Member Author

nohli commented Oct 13, 2022

@nohli seems that a conditional export did the trick!

Nice, so my dev intuition was right 😄

Thanks for trying and fixing! ❤️

@nohli nohli marked this pull request as ready for review October 13, 2022 11:42
Copy link
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just a couple of questions

@vbuberen
Copy link
Collaborator

I meant not just one line, but return info that was in podspec before 😄

@nohli nohli requested a review from vbuberen October 13, 2022 12:18
@vbuberen vbuberen merged commit 30f9bf6 into main Oct 13, 2022
@vbuberen vbuberen deleted the unfederate-device-info-plus branch October 13, 2022 17:54
@nohli
Copy link
Member Author

nohli commented Oct 13, 2022

@miquelbeltran what about this issue? Should we say he can apply the changes to the latest architecture?

(If we close it unmerged, does it still count towards hacktoberfest?)

@vbuberen
Copy link
Collaborator

(If we close it unmerged, does it still count towards hacktoberfest?)

It is not.

Should we say he can apply the changes to the latest architecture?

If he agrees to do so.

@miquelbeltran
Copy link
Member

I believe it counts because it has the labels.

@nohli
Copy link
Member Author

nohli commented Oct 13, 2022

If we want the change, we should communicate it in the other PR. Otherwise - if it's not updated - it can't be merged any more due to the new architecture.

Btw. could you also give my 5 refactoring PRs the labels?

@miquelbeltran
Copy link
Member

I will just fix the merge conflict and go ahead with it, I still like the idea of removing the toMap method eventually

@nohli nohli added the Hacktoberfest Issues taking part in Hacktoberfest label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants